Null pointer fixes #761
Null pointer fixes #761
Conversation
thekevinWHYuan
requested review from
StarDylan,
JLpro-cd,
bholt13 and
realkaranvir
|
What was the issue? / How'd you fix it? |
There was a problem hiding this comment.
Photo being sent was already encoded in base64.
There was a problem hiding this comment.
Decided to store base64 encoding in photoPath due to convenience and changing the entire schema seemed risky..
getPatientPhotoOrNull was the main culprit. It checked to see whether the photoID AND the photoPath wasn't null and if even one of them was, both of them would be null.
app/femr/common/ItemModelMapper.java
Outdated
There was a problem hiding this comment.
Stores base64 uri picture with the patient
|
Sorry about that Dylan, just added some explanations to the files |
|
Does this affect the triage image uploading for patient identification image? Have you tested that yet on your end? |
|
Patient identification image? Like the encounters? The encounters are fine with the changes |
|
When the patient is created in triage, their profile image |
|
It works fine |
|
Since patient photos are still working with this fix, LGTM! |
No description provided.