Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Roave ignore file #942

Merged
merged 4 commits into from
Feb 20, 2025
Merged

Fix Roave ignore file #942

merged 4 commits into from
Feb 20, 2025

Conversation

bram-pkg
Copy link
Member

@bram-pkg bram-pkg commented Feb 2, 2025

What is the reason for this PR?

  • A new feature
  • Fixed an issue (resolve #ID)

Author's checklist

Summary of changes

Review checklist

  • All checks have passed
  • Changes are added to the CHANGELOG.md
  • Changes are approved by maintainer

@bram-pkg bram-pkg requested a review from localheinz February 2, 2025 18:46
@pimjansen
Copy link

Since this will be a major, cant we just ignore this for now in the workflow?

@pimjansen pimjansen merged commit 36ab451 into 2.0 Feb 20, 2025
12 checks passed
@pimjansen pimjansen deleted the bram-pkg/fix-roave branch February 20, 2025 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants