Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(evaluation-context): Add ApplicationEvaluationContext, document schema fields #5203

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat(evaluation-context): Add ApplicationEvaluationContext, document schema fields #5203

wants to merge 3 commits into from

Conversation

khvn26
Copy link
Member

@khvn26 khvn26 commented Mar 10, 2025

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

This adds ApplicationEvaluationContext to the shared SDK evaluation context schema used by Golang and JS SDKs.

I also added descriptions to the new and current fields.

How did you test this code?

N/A

@vercel Vercel
Copy link

vercel bot commented Mar 10, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Mar 11, 2025 9:55am
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Visit Preview Mar 11, 2025 9:55am
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Visit Preview Mar 11, 2025 9:55am

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 10, 2025 •
edited
Loading

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-5203 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-5203 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-5203 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith:pr-5203 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-5203 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-frontend:pr-5203 Finished ✅ Results ✅

@github-actions github-actions bot added the feature New feature or request label Mar 10, 2025
@khvn26 khvn26 mentioned this pull request Mar 10, 2025
Open
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 10, 2025 •
edited
Loading

Uffizzi Ephemeral Environment deployment-61730

☁️ https://app.uffizzi.com/github.com/Flagsmith/flagsmith/pull/5203

📄 View Application Logs etc.

What is Uffizzi? Learn more!

@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Mar 10, 2025
@khvn26 khvn26 requested a review from kyle-ssg March 10, 2025 19:42
@khvn26 khvn26 assigned tiagoapolo and unassigned tiagoapolo Mar 10, 2025
khvn26
khvn26 commented Mar 11, 2025
View reviewed changes
khvn26
khvn26 commented Mar 11, 2025
View reviewed changes
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyle-ssg kyle-ssg Awaiting requested review from kyle-ssg

@tiagoapolo tiagoapolo Awaiting requested review from tiagoapolo

@matthewelwell matthewelwell Awaiting requested review from matthewelwell

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@khvn26 @tiagoapolo