CI check for #168 #169
Closed
CI check for #168 #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yay, the generic reports knit across all CI platforms with Kellie's bugfix. |
slager
force-pushed
the
noninteractive_plus_lonely_item_fix
branch
from
c056155 to
f6354b9
Compare
|
sweet! just noting that I've looked at this and am happy to see that with the bugfix everything is running smoothly! |
slager
force-pushed
the
noninteractive_plus_lonely_item_fix
branch
3 times, most recently
from
ad755eb to
6bdc79f
Compare
slager
force-pushed
the
noninteractive_plus_lonely_item_fix
branch
from
29522c3 to
4de833f
Compare
slager
force-pushed
the
noninteractive_plus_lonely_item_fix
branch
from
92732e9 to
0e07004
Compare
|
Leaving this draft PR open for now in case I need to push additional debug commits to it or refer to it in discussion with upstream r-lib. |
|
Closing, but leaving the branch here for now. |
|
Deleting branch since there hasn't been movement on this from upstream. Will resurrect later as needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE. This branch is just #168 with the bugfix from #159 merged in, to see if the CI runners can successfully test knit the generic report.