fix: Add create proposals. #8 #14
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zomglings @karacurt could you review this, if you are free |
|
Hey amazing @karacurt, would really appreciate a review on this one! ✨ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@karacurt @zomglings This PR introduces functionality for managing safe proposals in the proposal.go and proposalOperations.go files. Key highlights include:
Command Structure: Implements the CreateSafeProposalCmd command for creating new proposals.
Input Validation: Validates required flags --safe (safe address) and --to (recipient address) to ensure they are valid hex addresses.
Off-Chain Proposal Creation: Supports off-chain creation of safe proposals by utilizing the --to and --calldata flags for specifying the recipient and transaction data.
Transaction Preparation: Constructs the necessary transaction data and handles signature generation for proposals.
This enhancement streamlines the proposal creation process, ensuring accurate and efficient interactions with the Safe Transaction Service.
fixes#8.