Skip to content

fix: [REACT-350] make archived_at & pinned_at nullable #1515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 10, 2025

Conversation

arnautov-anton
Copy link
Contributor

Description of the changes, What, Why and How?

Extend ChannelMemberResponse's archived_at & pinned_at properties with null.

Copy link
Contributor

Size Change: 0 B

Total Size: 534 kB

ℹ️ View Unchanged
Filename Size
dist/browser.es.js 117 kB
dist/browser.full-bundle.min.js 63.8 kB
dist/browser.js 118 kB
dist/index.es.js 117 kB
dist/index.js 118 kB

compressed-size-action

@szuperaz
Copy link
Contributor

@arnautov-anton will it be undefined initially and null once someone removed an archive/pin?

@arnautov-anton
Copy link
Contributor Author

@arnautov-anton will it be undefined initially and null once someone removed an archive/pin?

Correct, when you unpin/unarchive member.updated returns a member object which has these properties set to null.

@arnautov-anton arnautov-anton changed the title fix: make archived_at & pinned_at nullable fix: [REACT-350] make archived_at & pinned_at nullable Apr 10, 2025
@arnautov-anton arnautov-anton merged commit 318825a into master Apr 10, 2025
6 checks passed
@arnautov-anton arnautov-anton deleted the fix/channel-member-response branch April 10, 2025 21:26
arnautov-anton added a commit that referenced this pull request Apr 17, 2025
## Description of the changes, What, Why and How?

Event handler for `member.updated` receives a `member` object which
contains `archived_at` and `pinned_at` with `null` values if
unarchive/unpin actions are called - to make matters for our integrators
easier, the only nullish value for these would be `undefined`. I'll keep
the types unchanged (#1515) as the `ChannelMemberResponse` used in the
`Event` type is still correct.
@github-actions github-actions bot mentioned this pull request Apr 17, 2025
arnautov-anton pushed a commit that referenced this pull request Apr 17, 2025
# 🚀 v8.60.0
  Make sure to use squash & merge when merging!
Once this is merged, another job will kick off automatically and publish
the package.
  # 📝 Changelog
##
[8.60.0](v8.59.0...v8.60.0)
(2025-04-17)


### Features

* [CHA-794] Add sort and filter param to queryThreads
([#1511](#1511))
([ea7fe99](ea7fe99))
* [CHA-855] - Refactoring partial update member
([#1517](#1517))
([e4f7e68](e4f7e68))


### Bug Fixes

* [REACT-350] make archived_at & pinned_at nullable
([#1515](#1515))
([318825a](318825a))
* [REACT-353] unify pinned_at & archived_at nullish values
([#1516](#1516))
([a840226](a840226)),
closes [#1515](#1515)

Co-authored-by: github-actions <release@getstream.io>
github-actions bot pushed a commit that referenced this pull request Apr 28, 2025
## [9.0.0-rc.11](v9.0.0-rc.10...v9.0.0-rc.11) (2025-04-28)

### ⚠ BREAKING CHANGES

* Replacement of FormatMessageResponse with LocalMessage
type

### Bug Fixes

* [REACT-344] remove Agora & 100ms integrations ([#1519](#1519)) ([16cd81a](16cd81a))
* [REACT-350] make archived_at & pinned_at nullable ([#1515](#1515)) ([318825a](318825a))
* [REACT-353] unify pinned_at & archived_at nullish values ([#1516](#1516)) ([a840226](a840226)), closes [#1515](#1515)

### Features

* [CHA-794] Add sort and filter param to queryThreads ([#1511](#1511)) ([ea7fe99](ea7fe99))
* [CHA-855] - Refactoring partial update member ([#1517](#1517)) ([e4f7e68](e4f7e68))
* message composer ([#1495](#1495)) ([0c07524](0c07524)), closes [stream-chat-react#2669](GetStream/stream-chat-react#2669)
@stream-ci-bot
Copy link

🎉 This PR is included in version 9.0.0-rc.11 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants