fix: [REACT-350] make archived_at & pinned_at nullable #1515
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnautov-anton
requested review from
vishalnarkhede,
santhoshvai,
khushal87,
szuperaz,
oliverlaz,
MartinCupela and
myandrienko
as code owners
|
Size Change: 0 B Total Size: 534 kB ℹ️ View Unchanged
|
|
@arnautov-anton will it be |
Correct, when you unpin/unarchive |
oliverlaz
approved these changes
Apr 10, 2025
szuperaz
approved these changes
Apr 10, 2025
arnautov-anton
changed the title
arnautov-anton
added a commit
that referenced
this pull request
Apr 17, 2025
## Description of the changes, What, Why and How? Event handler for `member.updated` receives a `member` object which contains `archived_at` and `pinned_at` with `null` values if unarchive/unpin actions are called - to make matters for our integrators easier, the only nullish value for these would be `undefined`. I'll keep the types unchanged (#1515) as the `ChannelMemberResponse` used in the `Event` type is still correct.
Merged
arnautov-anton
pushed a commit
that referenced
this pull request
Apr 17, 2025
# 🚀 v8.60.0 Make sure to use squash & merge when merging! Once this is merged, another job will kick off automatically and publish the package. # 📝 Changelog ## [8.60.0](v8.59.0...v8.60.0) (2025-04-17) ### Features * [CHA-794] Add sort and filter param to queryThreads ([#1511](#1511)) ([ea7fe99](ea7fe99)) * [CHA-855] - Refactoring partial update member ([#1517](#1517)) ([e4f7e68](e4f7e68)) ### Bug Fixes * [REACT-350] make archived_at & pinned_at nullable ([#1515](#1515)) ([318825a](318825a)) * [REACT-353] unify pinned_at & archived_at nullish values ([#1516](#1516)) ([a840226](a840226)), closes [#1515](#1515) Co-authored-by: github-actions <release@getstream.io>
github-actions bot
pushed a commit
that referenced
this pull request
Apr 28, 2025
## [9.0.0-rc.11](v9.0.0-rc.10...v9.0.0-rc.11) (2025-04-28) ### ⚠ BREAKING CHANGES * Replacement of FormatMessageResponse with LocalMessage type ### Bug Fixes * [REACT-344] remove Agora & 100ms integrations ([#1519](#1519)) ([16cd81a](16cd81a)) * [REACT-350] make archived_at & pinned_at nullable ([#1515](#1515)) ([318825a](318825a)) * [REACT-353] unify pinned_at & archived_at nullish values ([#1516](#1516)) ([a840226](a840226)), closes [#1515](#1515) ### Features * [CHA-794] Add sort and filter param to queryThreads ([#1511](#1511)) ([ea7fe99](ea7fe99)) * [CHA-855] - Refactoring partial update member ([#1517](#1517)) ([e4f7e68](e4f7e68)) * message composer ([#1495](#1495)) ([0c07524](0c07524)), closes [stream-chat-react#2669](GetStream/stream-chat-react#2669)
|
🎉 This PR is included in version 9.0.0-rc.11 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the changes, What, Why and How?
Extend
ChannelMemberResponse'sarchived_at&pinned_atproperties withnull.