fix: improve attachment upload error notification data #1542
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinCupela
requested review from
vishalnarkhede,
santhoshvai,
khushal87,
szuperaz,
oliverlaz,
arnautov-anton and
myandrienko
as code owners
|
Size Change: +398 B (+0.1%) Total Size: 382 kB
|
MartinCupela
force-pushed
the
fix/improve-attachment-upload-error-msg
branch
from
88d9893 to
14cdd43
Compare
…rror-msg # Conflicts: # src/messageComposer/attachmentManager.ts
Comment on lines
+463
to
+465
| metadata: { | ||
| reason: localAttachment.localMetadata.uploadPermissionCheck?.reason, | ||
| }, |
There was a problem hiding this comment.
Is it worth adding original error object at the same level the reason property is (if this is available in the UI)? ErrorFromResponse contains quite a bit of data which could be useful, like code and status numbers.
There was a problem hiding this comment.
But this not a error from a response. This is a reason calculated based on the back-end config.
There was a problem hiding this comment.
My bad, this was a wrong pick but there are other invocations where the error object is available.
| options: { | ||
| code: 'poll.creation.failed', | ||
| metadata: { | ||
| reason: (error as Error).message, |
Co-authored-by: Anton Arnautov <43254280+arnautov-anton@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Closes REACT-399
Provide more contextual information regarding the reasons of upload failure or blockage.
Add code property to the Notification type to allow to identify notifications based on a type (kind of a grouping).