Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make default configuration consistent #259

Closed
gep13 opened this issue Jul 26, 2020 · 5 comments · Fixed by #260
Closed

Make default configuration consistent #259

gep13 opened this issue Jul 26, 2020 · 5 comments · Fixed by #260

Comments

@gep13
Copy link
Member

gep13 commented Jul 26, 2020

The default configuration, for which labels are created by default, and which ones are included/excluded by default, should be consistent.

This was brought up as a result of the work that was done in #188.

The issues to include by default, should be updated to match what labels are created by default.

@gep13 gep13 added this to the 0.12.0 milestone Jul 26, 2020
@gep13
Copy link
Member Author

gep13 commented Jul 26, 2020

@akordowski did you fancy tackling this one as well? If so, happy to assign this to you.

@akordowski
Copy link
Contributor

@gep13 Yes, sure! But I'm not sure which changes you have in mind. Can you give me a hint?

@gep13
Copy link
Member Author

gep13 commented Jul 26, 2020

I am suggesting that we modify the following:

image

To match the list of labels that are created by GRM. i.e. it would be the following:

            IssueLabelsInclude = new List<string>
                                    {
                                        "Breaking Change",
                                        "Bug",
                                        "Documentation",
                                        "Feature",
                                        "Good First Issue",
                                        "Help Wanted",
                                        "Improvement",
                                        "Question"
                                    };

            IssueLabelsExclude = new List<string>
                                    {
                                        "Build",
                                    };

@akordowski
Copy link
Contributor

@gep13 I understand. Thanks!

@gep13 gep13 linked a pull request Jul 30, 2020 that will close this issue
gep13 pushed a commit that referenced this issue Jul 30, 2020
Including updating documentation where required.
gittools-bot pushed a commit that referenced this issue Jul 30, 2020
(GH-259) Make the default configuration consistent

Including updating documentation where required.
@gittools-bot
Copy link
Contributor

🎉 This issue has been resolved in version 0.12.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants