Assets on a draft release can be null

[Talkar]

Hi
It seems that when creating a new release with assets, the draft release will have a null entry for its assets.
I'm getting a NullReferenceException on this line

GitReleaseManager/src/GitReleaseManager.Core/VcsService.cs

Line 147 in 9d82f41

var existingAsset = release.Assets.FirstOrDefault(a => a.Name == assetFileName);

[Windos]

I'm also seeing this when trying to pass in an asset while creating a draft release. Adding the same asset to an existing draft release works.

grm create --milestone '0.1.0' --token $env:GitHubPAT --owner Windos --repository example --assets '.\Output\Manifest.0.1.0.json'

[FTL] Object reference not set to an instance of an object.
System.NullReferenceException: Object reference not set to an instance of an object.
   at GitReleaseManager.Core.VcsService.<AddAssetsAsync>d__13.MoveNext() in /_/src/GitReleaseManager.Core/VcsService.cs:line 147
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at GitReleaseManager.Core.VcsService.<CreateReleaseAsync>d__11.MoveNext() in /_/src/GitReleaseManager.Core/VcsService.cs:line 106
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at GitReleaseManager.Core.VcsService.<CreateReleaseFromMilestoneAsync>d__9.MoveNext() in /_/src/GitReleaseManager.Core/VcsService.cs:line 56
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at GitReleaseManager.Core.Commands.CreateCommand.<Execute>d__3.MoveNext() in /_/src/GitReleaseManager.Core/Commands/CreateCommand.cs:line 41
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at GitReleaseManager.Cli.Program.<Main>d__1.MoveNext() in /_/src/GitReleaseManager.Cli/Program.cs:line 34

[jibedoubleve]

How to reproduce it

I can reproduce the issue when I execute the command below

grm create --milestone 2.0.1 --token [HIDDEN] --owner OWNER --repository [REPOSITORY] --assets "D:/Projects/project/Publish/xxx.2.0.1-beta.64.bin.zip", "D:/Projects/project/Publish/xxx.2.0.1-beta.64.setup.exe"

What is happening?

The problem is that when I'm getting the release, I'm trying to find a released tagged 2.0.1. Because there's no release (sic.) with tag 2.0.1, NULL is returned

GitReleaseManager/src/GitReleaseManager.Core/VcsService.cs

Line 136 in c0d8b8e

var release = await _vcsProvider.GetReleaseAsync(owner, repository, tagName).ConfigureAwait(false);

Later, I'm trying to query the assets on a NULL collection of releases => NullReferenceException

GitReleaseManager/src/GitReleaseManager.Core/VcsService.cs

Line 147 in c0d8b8e

var existingAsset = release.Assets.FirstOrDefault(a => a.Name == assetFileName);

Why is it happening?

When creating a release with assets, it first creates the release, and then it uploads the assets. To upload the assets, we need the release, therefore we retrieve the created release.

It seems that when we try to retrieve the freshly created release, it's not yet available and this is the root cause of the NullReferenceException

How to fix it?

Instead of retrieving the release from the wire, we can provide the created release to the method that is in charge of uploading the assets

[gep13]

Huge thanks to @jibedoubleve who was able to figure out the solution to this problem, and provide a PR to get it working.

The issue will be addressed in the 0.14.0 release of GitReleaseManager.

[gittools-bot]

🎉 This issue has been resolved in version 0.14.0 🎉

The release is available on:

• GitHub Release
• NuGet Package
• Chocolatey Package
• .Net Global Tool

Your GitReleaseManager bot 📦🚀