Skip to content

feat(modelarmor): #9 Added snippets for create template with labels and metadata #5273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

tirthrajsinh-zala-crest
Copy link
Contributor

@tirthrajsinh-zala-crest tirthrajsinh-zala-crest commented Apr 11, 2025

Description

Added snippets for create template with labels and metadata

Checklist

  • I have followed Contributing Guidelines from CONTRIBUTING.MD
  • Tests pass: go test -v ./.. (see Testing)
  • Code formatted: gofmt (see Formatting)
  • Vetting pass: go vet (see Formatting)
  • These samples need a new API enabled in testing projects to pass (Model Armor API)
  • These samples need a new/updated env vars in testing projects set to pass (GOLANG_SAMPLES_LOCATION)
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Apr 11, 2025
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @tirthrajsinh-zala-crest, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

This pull request introduces new snippets for creating Model Armor templates with labels and metadata. It adds three new files: create_template.go, create_template_with_labels.go, and create_template_with_metadata.go, along with delete_template.go, get_template.go, go.mod, go.sum, modelarmor_test.go, and testdata/env/test.env. The changes include adding the modelarmor module to go.work and implementing functions to create, delete, and retrieve Model Armor templates, including those with labels and metadata.

Highlights

  • New Snippets: Adds snippets for creating Model Armor templates with labels and metadata.
  • File Additions: Introduces new files for creating, deleting, and retrieving Model Armor templates.
  • Module Inclusion: Includes the modelarmor module in the go.work file.

Changelog

Click here to see the changelog
  • go.work
    • Added the modelarmor module to the go.work file.
  • modelarmor/create_template.go
    • Added a new file with a function to create a Model Armor template with basic filters.
  • modelarmor/create_template_with_labels.go
    • Added a new file with a function to create a Model Armor template with custom labels and RAI filters.
  • modelarmor/create_template_with_metadata.go
    • Added a new file with a function to create a Model Armor template with template metadata and RAI filters.
  • modelarmor/delete_template.go
    • Added a new file with a function to delete a Model Armor template.
  • modelarmor/get_template.go
    • Added a new file with a function to get a Model Armor template.
  • modelarmor/go.mod
    • Added a new go module for modelarmor with dependencies.
  • modelarmor/go.sum
    • Added a go sum file for modelarmor module.
  • modelarmor/modelarmor_test.go
    • Added tests for creating Model Armor templates with and without labels and metadata.
  • modelarmor/testdata/env/test.env
    • Added test environment file.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.


A template's born,
With labels bright and bold,
Armor for the cloud.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces new snippets for creating Model Armor templates with labels and metadata. The code includes examples for creating, getting, and deleting templates, along with corresponding tests. Overall, the code is well-structured and easy to follow.

Merge Readiness

The code appears to be in good shape for merging. I am unable to directly approve the pull request, and recommend that others review and approve this code before merging. There are no critical or high severity issues, and the medium severity issues are relatively minor and can be addressed in future iterations if necessary.

Copy link

snippet-bot bot commented Apr 11, 2025

Here is the summary of changes.

You are about to add 2 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@telpirion telpirion self-assigned this Apr 11, 2025
Copy link
Collaborator

@telpirion telpirion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are several global issues in these samples that must be addressed.

@telpirion
Copy link
Collaborator

Here are the global issues that need to be resolved in this PR (and the other Model Armor PRs).

  • Cut the "Returns" and "Example" blocks in the Godoc.
  • Return only an error from the samples.
  • Instantiate the CallOption object outside of the call to NewClient().
  • Use the %w formatting verb in calls to fmt.Errorf().
  • Ensure that END region tags are outside of the final curly brace for the sample.
  • Do not provide a testenv file with environment variables

Copy link
Collaborator

@telpirion telpirion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good! There are only a couple of items to address. Please take care of them and I will merge. Thanks!

@telpirion telpirion enabled auto-merge (squash) April 23, 2025 18:31
auto-merge was automatically disabled April 24, 2025 12:43

Head branch was pushed to by a user without write access

@tirthrajsinh-zala-crest tirthrajsinh-zala-crest force-pushed the modelarmor-create-template-with-labels-metadata branch from 60f185c to abdee68 Compare April 25, 2025 05:57
@product-auto-label product-auto-label bot added the api: modelarmor Issues related to the Model Armor API. label May 2, 2025
@harshnasitcrest
Copy link
Contributor

This looks really good! There are only a couple of items to address. Please take care of them and I will merge. Thanks!

Done. Could you please help us merge this PR?

@tirthrajsinh-zala-crest tirthrajsinh-zala-crest changed the title feat(modelarmor): Added snippets for create template with labels and metadata feat(modelarmor): #9 Added snippets for create template with labels and metadata May 13, 2025
@telpirion telpirion enabled auto-merge (squash) May 19, 2025 19:27
auto-merge was automatically disabled May 20, 2025 04:42

Head branch was pushed to by a user without write access

@utsav1810 utsav1810 added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels May 23, 2025
@kokoro-team kokoro-team removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels May 23, 2025
@utsav1810 utsav1810 merged commit df79804 into GoogleCloudPlatform:main May 23, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: modelarmor Issues related to the Model Armor API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants