Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ape atoll agility course #615

Merged
merged 7 commits into from
Feb 20, 2025
Merged

Add ape atoll agility course #615

merged 7 commits into from
Feb 20, 2025

Conversation

GregHib
Copy link
Owner

@GregHib GregHib commented Feb 20, 2025

  • Add monkey greegrees
  • Add ape atoll agility course + tests
  • Fix sending empty delta's to exact move
  • Fix render emote reset ignoring transforms

Fix and expand greegree logic

Fix render emotes for greegrees

Clearing render emote takes current transform into account
Copy link

github-actions bot commented Feb 20, 2025

Qodana Community for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

Copy link

codecov bot commented Feb 20, 2025

Codecov Report

Attention: Patch coverage is 74.00531% with 98 lines in your changes missing coverage. Please review.

Project coverage is 35.43%. Comparing base (572ed8e) to head (8f67816).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../content/quest/member/monkey_madness/Greegrees.kts 23.33% 43 Missing and 3 partials ⚠️
...n/content/skill/agility/course/ApeAtollDungeon.kts 0.00% 24 Missing ⚠️
...n/kotlin/content/skill/agility/course/ApeAtoll.kts 96.21% 4 Missing and 6 partials ⚠️
...ps/engine/entity/character/player/PlayerVisuals.kt 0.00% 5 Missing ⚠️
...ain/kotlin/content/entity/player/combat/Attack.kts 58.33% 3 Missing and 2 partials ⚠️
...n/kotlin/content/entity/player/equip/Equipping.kts 50.00% 2 Missing and 1 partial ⚠️
.../gregs/voidps/engine/entity/character/Character.kt 0.00% 2 Missing ⚠️
...src/main/kotlin/content/entity/effect/Transform.kt 0.00% 1 Missing and 1 partial ⚠️
...ty/player/command/debug/PlayerUpdatingCommands.kts 0.00% 1 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
...n/content/area/wilderness/abyss/AbyssObstacles.kts 97.26% <100.00%> (ø)
...ty/player/command/debug/PlayerUpdatingCommands.kts 1.09% <0.00%> (ø)
.../gregs/voidps/engine/entity/character/Character.kt 10.60% <0.00%> (-0.17%) ⬇️
...src/main/kotlin/content/entity/effect/Transform.kt 60.00% <0.00%> (+60.00%) ⬆️
...n/kotlin/content/entity/player/equip/Equipping.kts 44.04% <50.00%> (-0.96%) ⬇️
...ps/engine/entity/character/player/PlayerVisuals.kt 18.42% <0.00%> (-1.03%) ⬇️
...ain/kotlin/content/entity/player/combat/Attack.kts 80.00% <58.33%> (-13.34%) ⬇️
...n/kotlin/content/skill/agility/course/ApeAtoll.kts 96.21% <96.21%> (ø)
...n/content/skill/agility/course/ApeAtollDungeon.kts 0.00% <0.00%> (ø)
.../content/quest/member/monkey_madness/Greegrees.kts 23.33% <23.33%> (ø)

... and 6 files with indirect coverage changes

@@             Coverage Diff              @@
##               main     #615      +/-   ##
============================================
+ Coverage     35.09%   35.43%   +0.33%     
- Complexity     4911     4916       +5     
============================================
  Files          1350     1353       +3     
  Lines         47557    47925     +368     
  Branches       9597     9663      +66     
============================================
+ Hits          16688    16980     +292     
- Misses        27440    27499      +59     
- Partials       3429     3446      +17     
Components Coverage Δ
Content 30.06% <75.40%> (+0.68%) ⬆️
Engine 43.12% <0.00%> (-0.03%) ⬇️
Network 71.85% <ø> (ø)

@GregHib GregHib merged commit 9195763 into main Feb 20, 2025
5 checks passed
@GregHib GregHib deleted the ape-atoll-course branch February 20, 2025 19:21
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This plugin/scripting system is gorgeous

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants