Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve naming 5 - Sounds #616

Merged
merged 5 commits into from
Feb 20, 2025
Merged

Improve naming 5 - Sounds #616

merged 5 commits into from
Feb 20, 2025

Conversation

GregHib
Copy link
Owner

@GregHib GregHib commented Feb 20, 2025

No description provided.

Copy link

Qodana Community for JVM

2 new problems were found

Inspection name Severity Problems
Unused symbol 🔶 Warning 2

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

Copy link

codecov bot commented Feb 20, 2025

Codecov Report

Attention: Patch coverage is 43.72093% with 121 lines in your changes missing coverage. Please review.

Project coverage is 35.43%. Comparing base (9195763) to head (4d9ab84).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
game/src/main/kotlin/content/entity/sound/Sound.kt 54.16% 11 Missing ⚠️
...otlin/content/area/misthalin/varrock/GypsyAris.kts 0.00% 9 Missing ⚠️
.../kotlin/content/area/misthalin/varrock/Delrith.kts 0.00% 8 Missing ⚠️
...ntent/area/misthalin/lumbridge/LumbridgeChurch.kts 22.22% 7 Missing ⚠️
...me/src/main/kotlin/content/skill/ranged/Ranged.kts 25.00% 6 Missing ⚠️
...ontent/area/misthalin/varrock/palace/SirPrysin.kts 0.00% 5 Missing ⚠️
.../kotlin/content/entity/player/modal/tab/Emotes.kts 0.00% 5 Missing ⚠️
.../content/area/misthalin/wizards_tower/Traiborn.kts 0.00% 4 Missing ⚠️
...in/content/skill/ranged/weapon/special/DarkBow.kts 0.00% 4 Missing ⚠️
...kotlin/content/area/wilderness/KingBlackDragon.kts 0.00% 3 Missing ⚠️
... and 44 more
Additional details and impacted files
Files with missing lines Coverage Δ
...lin/content/area/kandarin/ourania/OuraniaAltar.kts 67.50% <100.00%> (ø)
...n/content/area/wilderness/abyss/AbyssObstacles.kts 97.26% <100.00%> (ø)
.../src/main/kotlin/content/entity/death/NPCDeath.kts 61.81% <100.00%> (ø)
...src/main/kotlin/content/entity/gfx/SpawnGraphic.kt 100.00% <100.00%> (ø)
...c/main/kotlin/content/entity/npc/combat/Attack.kts 38.88% <100.00%> (ø)
...rc/main/kotlin/content/entity/obj/canoe/Canoes.kts 78.10% <100.00%> (ø)
...nt/entity/player/combat/special/SpecialAttacks.kts 50.00% <100.00%> (ø)
...n/kotlin/content/entity/player/equip/Equipping.kts 44.04% <100.00%> (ø)
...ent/entity/player/inv/item/destroy/ItemDestroy.kts 65.00% <100.00%> (ø)
...ntent/entity/player/inv/item/drop/ItemDropping.kts 68.75% <100.00%> (ø)
... and 65 more

... and 2 files with indirect coverage changes

@@            Coverage Diff            @@
##               main     #616   +/-   ##
=========================================
  Coverage     35.43%   35.43%           
  Complexity     4919     4919           
=========================================
  Files          1353     1352    -1     
  Lines         47925    47925           
  Branches       9663     9663           
=========================================
+ Hits          16982    16983    +1     
+ Misses        27500    27497    -3     
- Partials       3443     3445    +2     
Components Coverage Δ
Content 30.07% <43.72%> (+<0.01%) ⬆️
Engine 43.12% <ø> (ø)
Network 71.85% <ø> (ø)

@GregHib GregHib merged commit cdb6188 into main Feb 20, 2025
5 checks passed
@GregHib GregHib deleted the sound-naming branch February 20, 2025 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant