Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CfNoLookup #11825

Merged
merged 2 commits into from
Nov 18, 2024
Merged

Add CfNoLookup #11825

merged 2 commits into from
Nov 18, 2024

Conversation

Simn
Copy link
Member

@Simn Simn commented Nov 18, 2024

This adds a class field flag to mark fields as unlookupable for cases such as #11817. I've only implemented it for statics for now, but there might be other situations where we generate fields that we don't want to explicitly access.

The test I added fails on the unixes for some reason. @kLabz Any chance you could take a look at that?

@kLabz
Copy link
Contributor

kLabz commented Nov 18, 2024

Uh. I can repro locally, not sure yet why that completion request fails with {"jsonrpc":"2.0","id":1,"error":{"code":0,"message":"Compiler error","data":["No completion point"]}}

@kLabz
Copy link
Contributor

kLabz commented Nov 18, 2024

Oh, it's because Main.hx isn't invalidated, and file time check is not precise enough to see changes made right before. Need to invalidate or wait (or check file time with better precision, I can open a PR for that)

Works fine with runHaxeJson([], ServerMethods.Invalidate, {file: file}); before completion request.

@Simn
Copy link
Member Author

Simn commented Nov 18, 2024

Aaah right, it's always that...

@Simn Simn merged commit 6472d32 into development Nov 18, 2024
99 checks passed
@Simn Simn deleted the CfNoLookup branch November 18, 2024 13:57
@skial skial mentioned this pull request Nov 22, 2024
1 task
kLabz pushed a commit that referenced this pull request Mar 6, 2025
* add CfNoLookup

* invalidate
kLabz pushed a commit that referenced this pull request Mar 7, 2025
* add CfNoLookup

* invalidate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants