feat(TheWarWithin\Items.lua): Add Ingenious Mana Battery #4712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
joshjau
commented
Apr 8, 2025
joshjau
commented
- Adds support for APLs that use Ingenious Mana Battery.
- Adds support for APLs that use Ingenious Mana Battery.
Hekili
requested changes
Apr 8, 2025
Hekili
reviewed
Apr 10, 2025
|
I'm a little confused. I don't have this trinket to test, but from the tooltip, it seems like this is essentially a passive Versatility trinket as long as you gain the buff and keep your mana over 50%? The |
|
I went ahead and revised this to match addon behavior. It's a dumb trinket, though. |
|
I agree it is dumb, I do not even have it on any of my characters; I just noticed it was in the APL for some specs now annoyingly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.