-
-
Notifications
You must be signed in to change notification settings - Fork 10.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DevToys Preview 2.0.1 #175585
DevToys Preview 2.0.1 #175585
Conversation
Hi @veler - Based on this Devtoys issue that you're engaged on, it seems you are now the successor to the current DevToys Cask. It probably makes sense to utilize the existing Cask and refresh the urls, versions, etc rather than creating new. Unless there is some other reason? |
Hi @krehel , Also, this PR is currently in Draft because the Release on my GitHub is draft and not publicly available yet, meaning that for now, commands like |
No worries @veler! Happy to help and support. Some thoughts - I'd say unstable builds would go in a different Cask if you're going to consistently publish beta / daily / nightly builds (whatever not mainline releases) ahead of your stable builds that you want separated. Such as VS Code and VS Code Insiders. Some Casks publish stable builds multiple times per day and don't do a separate daily or beta schedule at all. For your situation here's some options -
Note the I guess it also depends how many people you're trying to get using DevToys beta whether you're cautioning the beta, or you find it's stable for daily driving but finalizing details. If you're confident in the current beta, I'd probably opt for the second option. From an end user perspective, both 1 and 2 would push the beta to them for testing. It's just more semantics on your release tagging. Option 3 obviously retains the release split. I'm not trying to tell you how to run your project though please bear in mind. ❤️ (n.b. I use DevToys on Mac and Windows, happy to test) |
Thanks for these insights @krehel, this is super helpful!
With that in mind, option 1 and 2 sound viable to me. I'm not sure to follow the difference between both though. Here is how versions are handled on my side:
Once we reached stable 2.0 release, as user count grow, further updates may or may not go to a preview channel based on how confident we feel with changes. But that's quite an unknown for now. What would you recommend based on that? |
I probably made this more complicated than needed. 😀 tl;dr: release 2.x.y.z like a normal More below: ⬇️ I'd say the simplest way is to mark your "beta" releases as just standard We don't usually take GitHub pre-releases unless expressly needed. We typically only do it for applications that mark everything as a pre-release. Most applications we filter out occasional pre-releases by looking for GitHub Again, I emphasize: not telling you how to run your project. You can build hourly releases as stable if you want of course. 😅 But given what I gather:
If you make a release marked as GitHub latest, 2.x.x.x, and we update the existing Cask with your repository information - on an end user update they will pull your version, no hassle with pre-release and exceptions. |
That's awesome!
That's exactly how we do.
Yep, we do NOT do that. Given your advice, I updated the PR to update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @veler - I have left some comments in the review to help for when you're ready to do the updates.
@bevanjkay , really appreciate all your feedback, thank you very much! |
Co-authored-by: Justin Krehel <39449589+krehel@users.noreply.github.com>
Hi @krehel , |
You should revert it back to draft status then. But merging requires someone with the branch permission, so that will need to be a maintainer. |
I see. Nevermind then. Let's merge it as soon as possible 😅 |
We will need to remove this from pre-release allow list once this goes stable. Thought we weren't going to use pre-release labels. Merging PR... |
I will maybe sur to remove it once not in Preview anymore. Thank you so much! |
Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.
In the following questions
<cask>
is the token of the cask you're submitting.After making any changes to a cask, existing or new, verify:
brew audit --cask --online <cask>
is error-free.brew style --fix <cask>
reports no offenses.