Standardize the likelihood acceptance algorithm between chimeric and … #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…global chains. The algorithms were similar, but on rare occasions produced contradictory results. now both use the same function to accept or reject an iteration.
|
Looks like some tests are failing giving 'sometimes worse likelihoods are being accepted'? |
|
I am converting this to a draft, as I made a new PR that includes these changes as well as some other inference fixes. @shauntruelove @saraloo |
|
The new PR looks good to me - happy to close this? |
|
yup agree we should close if everyone okays new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…global chains. The algorithms were similar, but on rare occasions produced contradictory results. now both use the same function to accept or reject an iteration.
Describe your changes.
This is the same as the previous PR, but starting from the correct version of main. Rebase had multiple errors, so this was cleaner.