Tasks done #5
Open
Tasks done #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tshemsedinov
requested changes
Dec 3, 2019
| @@ -1,7 +1,8 @@ | |||
| 'use strict'; | |||
|
|
|||
| const removeElements = (array, ...items) => { | |||
| // Remove multiple items from array modifying original array | |||
| for (const item of items) | |||
| array.includes(item) ? array.splice(array.indexOf(item), 1) : array; | |||
There was a problem hiding this comment.
Remove ternary to improve readability.
| // Remove item from array modifying original array | ||
| }; | ||
| const removeElement = (array, item) => | ||
| (array.includes(item) ? array.splice(array.indexOf(item), 1) : array); |
There was a problem hiding this comment.
Remove ternary to improve readability.
| const unique = array => { | ||
| const na = []; | ||
|
|
||
| array.forEach(i => { |
There was a problem hiding this comment.
Use for..of here, it's much faster and suitable in this case.
There was a problem hiding this comment.
I thought I need to use Array functions mostly, so decided to use forEach
| const difference = (array1, array2) => { | ||
| const na = []; | ||
|
|
||
| array1.forEach(i => { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.