Skip to content

Fix compilation errors for CUDA >= 12.6 #997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

FilipeMaia
Copy link

Fixes #996.

@albertmena albertmena requested a review from oierlauzi March 31, 2025 05:44
@albertmena
Copy link
Collaborator

Thanks @FilipeMaia for your contribution. Look like more changes are required to run Xmipp with CUDA 12.6

@FilipeMaia
Copy link
Author

FilipeMaia commented Mar 31, 2025

@albertmena The failed test does not seem to be testing the code included in the pull request. If you look at the output of https://github.com/I2PC/xmipp/actions/runs/14168721564/job/39687573985?pr=997#step:7:193 you see the hash returned is 7e6e032, not 7da7053 or db094de. (Looks like the link to the log is now a 404)

@albertmena
Copy link
Collaborator

I didn't see the hash! thanks.
Maybe is an issue related to the PR from the fork
Trying it: #999

Copy link
Collaborator

@oierlauzi oierlauzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @FilipeMaia for your PR

@MartinSalinas98
Copy link
Collaborator

MartinSalinas98 commented Mar 31, 2025

I didn't see the hash! thanks. Maybe is an issue related to the PR from the fork Trying it: #999

Taking into account that workflows are running as expected now in #999 and that they also did not run in #998, I'm guessing it was a temporary issue on GitHub's side that got resolved before enough people noticed as to open an incident report (no sign of it in their status page).

Most likely, adding a new push to this PR (either via a new commit or via an edition of any of the commits above) would trigger them again and I'd expect them to run just fine this time.

@albertmena
Copy link
Collaborator

albertmena commented Apr 1, 2025

Merged this PR #999 because a fail in the GitHubActions

@albertmena albertmena closed this Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Xmipp does not compile with CUDA >=12.6
4 participants