-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IBMPlexSansHebrew-ThinItalic.woff missing from 1.1.0 deliverable #183
Comments
This is an error in the css. IBM Plex Sans Hebrew does not contain any italic styles on purpose. |
By that you mean the automated scss creation in https://github.com/IBM/plex/blob/master/scripts/export-scss.js just in case I am picking you up incorrectly and it is how I am consuming the scss. |
Taking a look at this now 👀 |
I'm going to manually update the scss/css files and release, but the script will need to get updated at some point to be smarter and not generate css for font weights that don't exist. |
@ronanmulvaney this should be fixed in |
@alisonjoseph Don't have the privileges to reopen but not seeing any change in 1.1.2 and am still getting an error on |
Hi @ronanmulvaney, so sorry about that, I manually removed them and didn't realize the publish script re-ran the script to generate the files. Try |
Can confirm resolution at my end. Thanks for the quick turnaround. |
Thanks Alison! |
Your @ibm/plex/scss/sans-hebrew/thin/italic/_index.scss refers to
This file does not seem to exist in your deliverable and causes issues processing the css through an import of
@import "@ibm/plex/scss/ibm-plex";
The text was updated successfully, but these errors were encountered: