Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBMPlexSansHebrew-ThinItalic.woff missing from 1.1.0 deliverable #183

Closed
ronanmulvaney opened this issue Jul 31, 2018 · 9 comments
Closed

Comments

@ronanmulvaney
Copy link

Your @ibm/plex/scss/sans-hebrew/thin/italic/_index.scss refers to

    url('#{$font-prefix}/IBM-Plex-Sans-Hebrew/fonts/complete/woff/IBMPlexSansHebrew-ThinItalic.woff') format('woff');

image

This file does not seem to exist in your deliverable and causes issues processing the css through an import of @import "@ibm/plex/scss/ibm-plex";

@ronanmulvaney ronanmulvaney changed the title IBMPlexSansHebrew-ThinItalic.woff missing from 1.2.0 deliverable IBMPlexSansHebrew-ThinItalic.woff missing from 1.1.0 deliverable Jul 31, 2018
@BoldMonday
Copy link
Collaborator

This is an error in the css. IBM Plex Sans Hebrew does not contain any italic styles on purpose.

@ronanmulvaney
Copy link
Author

By that you mean the automated scss creation in https://github.com/IBM/plex/blob/master/scripts/export-scss.js just in case I am picking you up incorrectly and it is how I am consuming the scss.

@alisonjoseph
Copy link
Member

Taking a look at this now 👀

@alisonjoseph
Copy link
Member

I'm going to manually update the scss/css files and release, but the script will need to get updated at some point to be smarter and not generate css for font weights that don't exist.

@alisonjoseph
Copy link
Member

@ronanmulvaney this should be fixed in v1.1.2 Please reopen the issue if you are still seeing references to italic hebrew anywhere. Thanks!

@ronanmulvaney
Copy link
Author

@alisonjoseph Don't have the privileges to reopen but not seeing any change in 1.1.2 and am still getting an error on Can't resolve '@ibm/plex/IBM-Plex-Sans-Hebrew/fonts/complete/woff/IBMPlexSansHebrew-ThinItalic.woff'

@alisonjoseph
Copy link
Member

Hi @ronanmulvaney, so sorry about that, I manually removed them and didn't realize the publish script re-ran the script to generate the files. Try 1.1.3 when you have a chance, I installed it locally and I believe the references to Hebrew Italic are now removed.

@ronanmulvaney
Copy link
Author

Can confirm resolution at my end. Thanks for the quick turnaround.

@mjabbink
Copy link
Contributor

Thanks Alison!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants