Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Families.js generates scss for italic fonts that don’t exist for all languages #186

Open
alisonjoseph opened this issue Jul 31, 2018 · 6 comments
Open

Families.js generates scss for italic fonts that don’t exist for all languages #186

alisonjoseph opened this issue Jul 31, 2018 · 6 comments
Labels
type: bug 🐛

Comments

@alisonjoseph
Copy link
Member

families.js currently assumes all fonts have all weights, which is not the case. Needs to be updated to only generate scss/css for the font weights that exist.

Related to: #183
@alisonjoseph alisonjoseph mentioned this issue Sep 21, 2018
Closed
@alisonjoseph alisonjoseph mentioned this issue Oct 11, 2018
Closed
@joshblack joshblack self-assigned this Oct 11, 2018
@mjabbink
Copy link
Contributor

mjabbink commented Nov 1, 2018

All fonts have 8 weights.

@mjabbink mjabbink closed this as completed Nov 1, 2018
@alisonjoseph
Copy link
Member Author

Hey @mjabbink sorry I didn't name this issue correctly. Not all fonts have italic versions and the script generates scss for that.

@alisonjoseph alisonjoseph changed the title Families.js generates scss for font weights that don't exist Families.js generates scss for italic that fonts don't exist for all lannguages Nov 1, 2018
@alisonjoseph alisonjoseph changed the title Families.js generates scss for italic that fonts don't exist for all lannguages Families.js generates scss for italic that fonts don't exist for all languages Nov 1, 2018
@alisonjoseph alisonjoseph reopened this Nov 1, 2018
@alisonjoseph alisonjoseph changed the title Families.js generates scss for italic that fonts don't exist for all languages Families.js generates scss for italic fonts that don't exist for all languages Nov 1, 2018
@mjabbink
Copy link
Contributor

mjabbink commented Nov 1, 2018

gotcha

@mjabbink
Copy link
Contributor

mjabbink commented Nov 1, 2018

That is true. Hebrew and Thai do not have Italics. The upcoming Devanagari and Arabic also do not have italics. Should I close this issue or leave open?

@alisonjoseph
Copy link
Member Author

We should leave open for now, @joshblack is going to help to fix the script to generate the correct files. It may also make sense to keep this repo to only hold the fonts, and move the sass file generation to the elements repo.

@sockol
Copy link
Contributor

sockol commented Dec 18, 2018 •
edited
Loading

Kind of resolved on the most recent version - it will still generate the italic folders for non-english languages, but it will not import them. So it's usable for now

@mjabbink mjabbink changed the title Families.js generates scss for italic fonts that don't exist for all languages Families.js generates scss for italic fonts that don’t exist for all languages Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug 🐛
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@mattrosno @sockol @alisonjoseph @joshblack @mjabbink