Skip to content

For issue 1575: Eliminating Manual Class Registration in Unitxt, replaced by Import Paths #1713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

For issue 1575: Eliminating Manual Class Registration in Unitxt, replaced by Import Paths #1713

wants to merge 1 commit into from

Conversation

dafnapension
Copy link
Collaborator

@dafnapension dafnapension commented Apr 5, 2025 •
edited
Loading

__type__ in catalog is expressed as qualified class name, therefrom classes are instantiated through python's import utils.

@dafnapension dafnapension force-pushed the json branch 2 times, most recently from d9425b2 to 3c9f7fa Compare April 6, 2025 20:22
@elronbandel
Copy link
Member

For: #1575

@dafnapension dafnapension force-pushed the json branch 10 times, most recently from 54efa18 to 137df10 Compare April 9, 2025 20:51
@dafnapension dafnapension changed the title __type__ in catalog to be expressed as qualified class name, registry maps each such qualified class name to itself, toward removal of registry __type__ in catalog is expressed as qualified class name, thereby classes are instantiated from it through python's import. Artifact.class_register is removed altogether Apr 9, 2025
@dafnapension dafnapension changed the title __type__ in catalog is expressed as qualified class name, thereby classes are instantiated from it through python's import. Artifact.class_register is removed altogether For issue 1575: Eliminating Manual Class Registration in Unitxt with Import Paths Apr 10, 2025
@dafnapension dafnapension changed the title For issue 1575: Eliminating Manual Class Registration in Unitxt with Import Paths For issue 1575: Eliminating Manual Class Registration in Unitxt, replaced by Import Paths Apr 10, 2025
@dafnapension dafnapension force-pushed the json branch 2 times, most recently from 83458db to 5c835c1 Compare April 10, 2025 20:27
@dafnapension dafnapension force-pushed the json branch 4 times, most recently from 1ef8d61 to 663239e Compare May 4, 2025 19:18
@dafnapension dafnapension force-pushed the json branch 3 times, most recently from 429047d to f3e6412 Compare May 20, 2025 15:42
@dafnapension
Copy link
Collaborator Author

dafnapension commented May 20, 2025 •
edited
Loading 

(virtual310) dafna@LENAHUVA:~/workspaces/unitxt$ git diff --name-only main json | grep -v catalog
docs/conf.py
prepare/metrics/custom_f1.py
src/unitxt/artifact.py
src/unitxt/deprecation_utils.py
src/unitxt/register.py
src/unitxt/settings_utils.py
tests/library/test_artifact.py
tests/library/test_artifact_recovery.py
tests/library/test_artifact_registration.py
tests/library/test_function_operators.py
tests/library/test_operators.py
tests/library/test_recipe.py
(virtual310) dafna@LENAHUVA:~/workspaces/unitxt$

@dafnapension dafnapension force-pushed the json branch 3 times, most recently from b0fc597 to d576e03 Compare May 20, 2025 20:31
@dafnapension dafnapension force-pushed the json branch 3 times, most recently from 1526060 to d7e2f90 Compare May 22, 2025 06:12
@dafnapension
change each __type__ in catalog to full qualified name, rather than s…
bfa1e35 
…nake of class name, and remove _class_register altogether

Signed-off-by: dafnapension <dafnashein@yahoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dafnapension @elronbandel