Skip to content

fix issues when running tests with all integer dtypes on GPU w/o support for fp64 #2430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 30, 2025

Conversation

vtavana
Copy link
Collaborator

@vtavana vtavana commented Apr 29, 2025

The following tests fails when running the test suite with all integer dtypes included on a GPU device that does not support fp64.

FAILED dpnp/tests/test_linalg.py::TestCond::test_basic
FAILED dpnp/tests/test_linalg.py::TestSvd::test_svd
FAILED dpnp/tests/test_linalg.py::TestPinv::test_pinv
FAILED dpnp/tests/third_party/cupy/creation_tests/test_ranges.py::TestRanges::test_linspace_mixed_start_stop2
FAILED dpnp/tests/third_party/cupy/math_tests/test_explog.py::TestExplog::test_logaddexp2
FAILED dpnp/tests/third_party/cupy/math_tests/test_trigonometric.py::TestUnwrap::test_unwrap_1dim_with_discont_and_period
FAILED dpnp/tests/third_party/cupy/math_tests/test_trigonometric.py::TestUnwrap::test_unwrap_1dim_with_period

This PR fixes them all.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

@vtavana vtavana self-assigned this Apr 29, 2025
Copy link
Contributor

github-actions bot commented Apr 29, 2025

View rendered docs @ https://intelpython.github.io/dpnp/index.html

Copy link
Contributor

github-actions bot commented Apr 29, 2025

Array API standard conformance tests for dpnp=0.18.0dev1=py312he4f9c94_13 ran successfully.
Passed: 1222
Failed: 0
Skipped: 9

@coveralls
Copy link
Collaborator

coveralls commented Apr 29, 2025

Coverage Status

coverage: 72.271%. first build
when pulling 146622d on all-int-gpu
into 4d2be8c on master.

@vtavana vtavana marked this pull request as ready for review April 29, 2025 22:29
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vtavana, LGTM

@vtavana vtavana merged commit 6a81e55 into master Apr 30, 2025
65 checks passed
@vtavana vtavana deleted the all-int-gpu branch April 30, 2025 14:19
github-actions bot added a commit that referenced this pull request Apr 30, 2025
…ort for fp64 (#2430)

The following tests fails when running the test suite with all integer
dtypes included on a GPU device that does not support fp64.

FAILED dpnp/tests/test_linalg.py::TestCond::test_basic
FAILED dpnp/tests/test_linalg.py::TestSvd::test_svd
FAILED dpnp/tests/test_linalg.py::TestPinv::test_pinv
FAILED
dpnp/tests/third_party/cupy/creation_tests/test_ranges.py::TestRanges::test_linspace_mixed_start_stop2
FAILED
dpnp/tests/third_party/cupy/math_tests/test_explog.py::TestExplog::test_logaddexp2
FAILED
dpnp/tests/third_party/cupy/math_tests/test_trigonometric.py::TestUnwrap::test_unwrap_1dim_with_discont_and_period
FAILED
dpnp/tests/third_party/cupy/math_tests/test_trigonometric.py::TestUnwrap::test_unwrap_1dim_with_period

This PR fixes them all. 6a81e55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants