CDDL improvements #4996
CDDL improvements #4996
Conversation
Soupstraw
force-pushed
the
jj/cddl-ordering
branch
14 times, most recently
from
daf12fe to
f070721
Compare
Soupstraw
force-pushed
the
jj/cddl-ordering
branch
6 times, most recently
from
75adbcb to
10739f9
Compare
| @@ -18,6 +18,12 @@ source-repository-package | |||
| -- MAKE SURE THIS POINTS TO A COMMIT IN `*-artifacts` BEFORE MERGE! | |||
| tag: cccfde6934ab0988fee3885ee160fffe04aa8274 | |||
|
|
|||
| source-repository-package | |||
There was a problem hiding this comment.
Can't we release this first? I worry adding this SRP like this.
There was a problem hiding this comment.
I'm a bit conflicted about this at the moment. The changes that I made to cuddle work fine for our use case, but it seems to be worse in some other aspects. I'd like to make it more stable before I release it, because consensus also wants to use cuddle for testing.
There was a problem hiding this comment.
We can't merge this PR with SRP on cuddle, since it would yield ledger packages unreleasable.
libs/cardano-ledger-core/testlib/Test/Cardano/Ledger/Core/Binary/CDDL.hs
Show resolved
Hide resolved
Soupstraw
force-pushed
the
jj/cddl-ordering
branch
3 times, most recently
from
5aee68a to
2eccb20
Compare
There was a problem hiding this comment.
This looks great! Love the new formatting, comment placing and ability to specify the order of definitions.
Nice work @Soupstraw
| @@ -18,6 +18,12 @@ source-repository-package | |||
| -- MAKE SURE THIS POINTS TO A COMMIT IN `*-artifacts` BEFORE MERGE! | |||
| tag: cccfde6934ab0988fee3885ee160fffe04aa8274 | |||
|
|
|||
| source-repository-package | |||
There was a problem hiding this comment.
We can't merge this PR with SRP on cuddle, since it would yield ledger packages unreleasable.
Soupstraw
force-pushed
the
jj/cddl-ordering
branch
from
2eccb20 to
bfe77e1
Compare
Description
This PR uses a newer version of
cuddle, which makes it possible to manually specify the order in which Huddle definitions appear. Also some of the comments about fields are now attached to the fields themselves, instead of being printed out in a long comment in front of the definition.The pretty printer has also been improved a bit, but there are still many places where the formatting is a bit off. The pretty printer could still be improved a lot, but at least the current version is a bit closer to what I'd like it to be once it's finished.
Checklist
CHANGELOG.mdfiles updated for packages with externally visible changes.NOTE: New section is never added with the code changes. (See RELEASING.md).
.cabalandCHANGELOG.mdfiles when necessary, according to theversioning process.
.cabalfiles updated when necessary.NOTE: If bounds change in a cabal file, that package itself must have a version increase. (See RELEASING.md).
scripts/fourmolize.sh).scripts/cabal-format.sh).hie.yamlupdated (usescripts/gen-hie.sh).