Skip to content

chore adding extra details to unit test scenarios #2051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 31, 2024

Conversation

nicky6s
Copy link
Contributor

@nicky6s nicky6s commented Jul 30, 2024

I have a future change in mind to do with CTEs. When I make the PR for this change I would like the unit tests changes (if any) to be simple and easy to understand. So, before I start to look at my CTE related change, I've added extra details to the UpdateTest, InsertTest, DeleteTest and SelectTest unit test scenarios.

There are zero functionality changes made here, only unit tests updates, I've been very careful not to change any SQL statements being tested.

Copy link
Contributor

@manticore-projects manticore-projects left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please refactor the duplicate/redundant parser calls.

@manticore-projects manticore-projects merged commit 21c605e into JSQLParser:master Jul 31, 2024
1 of 3 checks passed
@manticore-projects
Copy link
Contributor

Thank you for this contribution.

@nicky6s nicky6s deleted the extra-with-unit-tests branch July 31, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants