Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update preference text to 'Download referenced files (PDFs, ...) #12582

Merged
merged 2 commits into from
Feb 27, 2025

Conversation

gepetton
Copy link
Contributor

@gepetton gepetton commented Feb 27, 2025

fixes #12560

This PR updates the text for the "Download linked online files" checkbox in JabRef's UI and synchronizes the user documentation to reflect the current behavior. The changes address feedback that the previous description was misleading

12560

Link to Issue: #12560
Related Documentation PR: JabRef/user-documentation#552

Mandatory checks

  • I own the copyright of the code submitted and I licence it under the MIT license
  • Change in CHANGELOG.md described in a way that is understandable for the average user (if change is visible to the user)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JUnit tests are failing. In the area "Some checks were not successful", locate "Tests / Unit tests (pull_request)" and click on "Details". This brings you to the test output.
You can then run these tests in IntelliJ to reproduce the failing tests locally. We offer a quick test running howto in the section Final build system checks in our setup guide.

@gepetton gepetton marked this pull request as ready for review February 27, 2025 12:26
@Siedlerchr Siedlerchr added this pull request to the merge queue Feb 27, 2025
Merged via the queue into JabRef:main with commit 3d4c5c0 Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace "Download linked online files" by "Download references files (PDFs, ...)"
2 participants