This repository was archived by the owner on Jan 14, 2019. It is now read-only.
feat: rest element should contain information about type annotation #108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesHenry
previously approved these changes
Jan 10, 2019
|
can you merge #110 before this one? |
|
Done 👍 |
BREAKING CHANGE: This changes the AST for RestElement node
armano2
force-pushed
the
typed-rest-element
branch
from
7c1be31 to
ae66a85
Compare
JamesHenry
added a commit
that referenced
this pull request
Jan 10, 2019
BREAKING CHANGE: This changes the AST for RestElement node
|
🎉 This PR is included in version 14.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes typeAnnotation location in AST,
after this change typeAnnotation will be correctly assigned to RestElement node.
i think this is a little more logical, type annotation describe
...foonotfooin this caseexample: