This repository was archived by the owner on Jan 14, 2019. It is now read-only.
test: add FixturesTester #67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this will allow to run tests with TypeAssertions
2 tasks
|
github diff don't want to be nice and make diff readable... |
armano2
changed the title
|
https://github.com/JamesHenry/typescript-estree/pull/67/files?w=1 might look a little better |
|
@j-f1 what do you think about this anyway? |
|
I personally wouldn't have invested time in this, as it does not appear to add any new capabilities or fix any pain points vs the original code, but there is certainly nothing wrong with the changes you have made. If you want to fix up the conflicts, I am happy to merge it in |
|
🎉 This PR is included in version 10.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes way how alignment tests are generated.
FixturesTesteris helper class which makes all what previouslycreateFixturePatternConfigFor,fixturesRequiringSourceTypeModule, and those loops was doing before in way cleaner way.