feat: fix parsing comments in jsx #82
Conversation
| const triviaScanner = ts.createScanner( | ||
| ast.languageVersion, | ||
| false, | ||
| ast.languageVariant, |
There was a problem hiding this comment.
we have to provide language variant, 0/1
armano2
changed the title
armano2
changed the title
| container.parent && | ||
| container.parent.kind === ts.SyntaxKind.JsxOpeningElement && | ||
| container.parent.parent && | ||
| container.parent.parent.kind === ts.SyntaxKind.JsxElement |
There was a problem hiding this comment.
i had to do this instead of checking if type is equal JsxSelfClosingElement due to:
https://github.com/JamesHenry/typescript-estree/blob/master/src/convert.ts#L2091
i'm going to change logic there latter, to not mutate TS tree
| loc: true, | ||
| range: true, | ||
| tokens: true, | ||
| comment: true, | ||
| jsx: true | ||
| jsx: path.extname(filename) === '.js' |
There was a problem hiding this comment.
Are we missing anything important when we only enable jsx on .js files and not the .ts files? How come this change was necessary for this fix?
There was a problem hiding this comment.
there was no test cases for ts files in comments
TypeAssertion has same syntax as JSX <FOO> can be jsx or TypeAssertion, this change make sure that ts files are parsed without jsx flag set to true
|
The most recent breaking change affects this PR, so the build failed just FYI |
|
🎉 This PR is included in version 10.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
@vjeux @Kovensky @j-f1
This PR fixes issue with
//inside jsxfixes: #6