Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: fido2 needs to search cache for session instead of persistent storage when its caching is enabled #5975

Closed
aliaksander-samuseu opened this issue Sep 6, 2023 · 1 comment
Closed

feat: fido2 needs to search cache for session instead of persistent storage when its caching is enabled #5975

aliaksander-samuseu opened this issue Sep 6, 2023 · 1 comment
Assignees
@yurem @moabu
Labels
kind-feature Issue or PR is a new feature request

Comments

@aliaksander-samuseu
Copy link
Contributor

aliaksander-samuseu commented Sep 6, 2023 •
edited
Loading

Description
As reported in support ticket 11386, Fido doesn't seem to search appropriate storage for sessionId when "sessionIdPersistInCache" property is set to "True". As @yuriyz wrote:

It refers to https://github.com/JanssenProject/jans/blob/main/jans-fido2/server/src/main/java/io/jans/fido2/service/persist/UserSessionIdService.java#L125
Sounds like there no check in cache for session

Also, according to @Milton-Ch :

Fido2 does not have a cache implemented at the time of obtaining a session by id.
@yurem yurem self-assigned this Sep 7, 2023
yurem added a commit that referenced this issue Sep 12, 2023
@yurem
feat: fido2 needs to search cache for session instead of persistent
4602e39 
storage when its caching is enabled #5975
@yurem yurem changed the title Fido2 needs to search cache for session instead of persistent storage when its caching is enabled feat: fido2 needs to search cache for session instead of persistent storage when its caching is enabled Sep 12, 2023
@mo-auto mo-auto added the kind-feature Issue or PR is a new feature request label Sep 12, 2023
@yurem yurem mentioned this issue Sep 12, 2023
Merged
@yurem
Copy link
Contributor

yurem commented Sep 12, 2023

Implemented

@yurem yurem closed this as completed Sep 12, 2023
yuriyz pushed a commit that referenced this issue Sep 12, 2023
@yurem
feat: fido2 needs to search cache for session instead of persistent (#…
0cc0c19 
…6011)

* feat: fido2 needs to search cache for session instead of persistent
storage when its caching is enabled #5975

* chore: update expiration calculation
devrimyatar pushed a commit that referenced this issue Dec 30, 2023
@yurem @devrimyatar
feat: fido2 needs to search cache for session instead of persistent (#…
b6de748 
…6011)

* feat: fido2 needs to search cache for session instead of persistent
storage when its caching is enabled #5975

* chore: update expiration calculation

Signed-off-by: Mustafa Baser <mbaser@mail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yurem yurem

@moabu moabu

Labels
kind-feature Issue or PR is a new feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@yurem @aliaksander-samuseu @moabu @mo-auto