Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(jans-config-api): enhancements to saml api #7362

Open
uprightech opened this issue Jan 15, 2024 · 1 comment
Open

feat(jans-config-api): enhancements to saml api #7362

uprightech opened this issue Jan 15, 2024 · 1 comment
Assignees
@uprightech
Labels
comp-jans-config-api Component affected by issue or PR enhancement kind-feature Issue or PR is a new feature request
Milestone
next-release

Comments

@uprightech
Copy link
Contributor

  • Add endpoint to fetch metadata for trust relationship
  • Change of method name(s) to lift ambiguity during openapi code generation
@uprightech uprightech self-assigned this Jan 15, 2024
@mo-auto mo-auto added the kind-feature Issue or PR is a new feature request label Jan 15, 2024
@uprightech uprightech changed the title feat(config-api): enhancements to saml api feat(jans-config-api): enhancements to saml api Jan 15, 2024
@mo-auto mo-auto added the comp-jans-config-api Component affected by issue or PR label Jan 15, 2024
uprightech added a commit that referenced this issue Mar 7, 2024
@uprightech
feat(jans-config-api): enhancements to saml api #7362
972ec2a 
* added endpoint to retrieve file metadata for trustrelationship

Signed-off-by: Rolain Djeumen <uprightech@gmail.com>
uprightech added a commit that referenced this issue Mar 7, 2024
@uprightech
feat(jans-config-api): enhancements to saml api #7362
936eac0 
* added newly generate swagger yaml for kc-saml-plugino

Signed-off-by: Rolain Djeumen <uprightech@gmail.com>
uprightech added a commit that referenced this issue Mar 7, 2024
@uprightech
feat(jans-config-api): enhancements to saml api #7362
62c53fe 
* pluralized the operationid for the endpoint retrieving all trust relationships

Signed-off-by: Rolain Djeumen <uprightech@gmail.com>
@uprightech
Copy link
Contributor Author

Test cases

1. Get metadata file for an SP that doesn't exist

  • Invoke endpoint jans-config-api/kc/saml/trust-relationship/sp-metadata-file/00000000-0000-0000-0000-000000000000
  • Return code should be 404 , body should be message indicating the trust relationship was not found

2. Get metadata file for a SP that exists (file metadata source type)

  • Create a new SP , making sure it's metadata source type is file. Note it's inum
  • Invoke endpoint jans-config-api/kc/saml/trust-relationship/sp-metadata-file/<inum> where <inum> is the SP's inum
  • Return code should be 200, mime type should be application/xml and body should be the metadata in xml

3. Get metadata file for a SP that exists but isn't a file metadata source type

  • Create a new SP , making sure it's metadata source type is manual. Note it's inum
  • Invoke endpoint jans-config-api/kc/saml/trust-relationship/sp-metadata-file/<inum> where <inum> is the SP's inum
  • Return code should be 400 , body should be message indicating the trustrelationship metadata type isn't FILE

yuriyz pushed a commit that referenced this issue Mar 7, 2024
@uprightech
feat(jans-config-api): enhancements to saml api #7362 (#7989)
fc1e662 
* feat(jans-config-api): enhancements to saml api
* added method to get the trustrelationship metadata as a stream

Signed-off-by: Rolain Djeumen <uprightech@gmail.com>

* feat(jans-config-api): enhancements to saml api
* added method to SamlIdpService to get file from the DocumentStore

Signed-off-by: Rolain Djeumen <uprightech@gmail.com>

* feat(jans-config-api): enhancements to saml api #7362
* added endpoint to retrieve file metadata for trustrelationship

Signed-off-by: Rolain Djeumen <uprightech@gmail.com>

* feat(jans-config-api): enhancements to saml api #7362
* added newly generate swagger yaml for kc-saml-plugino

Signed-off-by: Rolain Djeumen <uprightech@gmail.com>

* feat(jans-config-api): enhancements to saml api #7362
* pluralized the operationid for the endpoint retrieving all trust relationships

Signed-off-by: Rolain Djeumen <uprightech@gmail.com>

---------

Signed-off-by: Rolain Djeumen <uprightech@gmail.com>
uprightech added a commit that referenced this issue Mar 8, 2024
@uprightech
feat(jans-config-api): enhancements to saml api #7362
0d6d97f 
* fixed vulnerability

Signed-off-by: Rolain Djeumen <uprightech@gmail.com>
moabu pushed a commit that referenced this issue Mar 8, 2024
@uprightech
feat(jans-config-api): enhancements to the saml api #7362 (#8001)
f66d4d4
@moabu moabu added this to the 1.1.4 milestone Jul 8, 2024
@moabu moabu modified the milestones: 1.1.4, 1.1.5 Sep 3, 2024
@moabu moabu modified the milestones: 1.1.5, 1.1.6 Sep 16, 2024
yuriyz pushed a commit that referenced this issue Nov 7, 2024
@uprightech
feat(jans-config-api): enhancements to saml api #7362 (#7989)
c1a4c0e 
* feat(jans-config-api): enhancements to saml api
* added method to get the trustrelationship metadata as a stream

Signed-off-by: Rolain Djeumen <uprightech@gmail.com>

* feat(jans-config-api): enhancements to saml api
* added method to SamlIdpService to get file from the DocumentStore

Signed-off-by: Rolain Djeumen <uprightech@gmail.com>

* feat(jans-config-api): enhancements to saml api #7362
* added endpoint to retrieve file metadata for trustrelationship

Signed-off-by: Rolain Djeumen <uprightech@gmail.com>

* feat(jans-config-api): enhancements to saml api #7362
* added newly generate swagger yaml for kc-saml-plugino

Signed-off-by: Rolain Djeumen <uprightech@gmail.com>

* feat(jans-config-api): enhancements to saml api #7362
* pluralized the operationid for the endpoint retrieving all trust relationships

Signed-off-by: Rolain Djeumen <uprightech@gmail.com>

---------

Signed-off-by: Rolain Djeumen <uprightech@gmail.com>
Former-commit-id: fc1e662
yuriyz pushed a commit that referenced this issue Nov 7, 2024
@uprightech
feat(jans-config-api): enhancements to the saml api #7362 (#8001)
efc2b8e 
Former-commit-id: f66d4d4
@moabu moabu modified the milestones: 1.1.6, next-release Nov 21, 2024
@moabu moabu modified the milestones: 1.2.0, next release Dec 24, 2024
@moabu moabu modified the milestones: 1.3.0, next-release Jan 21, 2025
@moabu moabu modified the milestones: 1.4.0, next-release Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@uprightech uprightech

Labels
comp-jans-config-api Component affected by issue or PR enhancement kind-feature Issue or PR is a new feature request
Projects
None yet
Milestone
next-release
Development

No branches or pull requests
3 participants
@uprightech @moabu @mo-auto