Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jans-tarp): issues found in tarp #8007

Closed
duttarnab opened this issue Mar 8, 2024 · 1 comment · Fixed by #8011
Closed

fix(jans-tarp): issues found in tarp #8007

duttarnab opened this issue Mar 8, 2024 · 1 comment · Fixed by #8011
Assignees
Labels
comp-jans-tarp kind-bug Issue or PR is a bug in existing functionality

Comments

@duttarnab
Copy link
Contributor

image

@duttarnab duttarnab added kind-bug Issue or PR is a bug in existing functionality comp-jans-tarp labels Mar 8, 2024
@duttarnab duttarnab self-assigned this Mar 8, 2024
@duttarnab duttarnab changed the title fix(jans-tarp): issues founf in tarp fix(jans-tarp): issues found in tarp Mar 10, 2024
@duttarnab
Copy link
Contributor Author

duttarnab commented Mar 10, 2024

Once set, the additional params text box is ready-only. I can't edit it. I am using chrome and latest version of tarp that I built from latest code base.

  • working to fix

The message on the top needs to be correct, Submit ..... to create a new OIDC client. Actually, on this screen, we are just initiating a auth flow. Client has already been created.

  • Changed message on top --- Enter inputs (optional) before initiating authentication flow.

In previous tarp version, instead of trigger, it says mentions which flow, like auth code. That information is useful for the developer.

  • change button name to --- Trigger Auth Flow

Also, the scope input on the client creation page doesn't seem to be having any effect as the newly created client doesn't have any scopes attached when checking from TUI.

  • Only those scopes can be added to the clients using DCR whose jansDefScope attribute is set to true. You can add any of the jansDefScope enabled scopes to the client using the registration form.

image

image

the additional parameters input box is marked with a *, but it is actually optional.

  • working to fix

The Tarp version on Firefox extension library is old. Need to upload the new one there.

  • I will submit a request for Firefox extension upgrade once the latest release is done.

duttarnab added a commit that referenced this issue Mar 10, 2024
Signed-off-by: Arnab Dutta <arnab.bdutta@gmail.com>
moabu added a commit that referenced this issue Mar 11, 2024
Signed-off-by: Arnab Dutta <arnab.bdutta@gmail.com>
Co-authored-by: Mohammad Abudayyeh <47318409+moabu@users.noreply.github.com>
yuriyz pushed a commit that referenced this issue Nov 7, 2024
Signed-off-by: Arnab Dutta <arnab.bdutta@gmail.com>
Co-authored-by: Mohammad Abudayyeh <47318409+moabu@users.noreply.github.com>
Former-commit-id: 29d489e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp-jans-tarp kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant