Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(fido2): make mds and attestation optional #5409

Merged
merged 1 commit into from
Sep 1, 2023
Merged

feat(fido2): make mds and attestation optional #5409

merged 1 commit into from
Sep 1, 2023

Conversation

Milton-Ch
Copy link
Contributor

@Milton-Ch Milton-Ch commented Jul 5, 2023 •
edited
Loading

Prepare

Description

  • Added 2 new configuration parameters:
    • skipDownloadMdsEnabled: Boolean value indicating whether the MDS download should be omitted
    • skipValidateMdsInAttestationEnabled: Boolean value indicating whether MDS validation should be omitted during attestation
  • Skip MDS validation in attestation for packet, fido-u2f, tpm, android-key, android-safetynet and apple

closes #5171

@mo-auto mo-auto added comp-jans-fido2 Component affected by issue or PR kind-feature Issue or PR is a new feature request labels Jul 5, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 5, 2023

[jans-pycloudlib] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 5, 2023

[jans-cli] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 5, 2023

[jans-linux-setup] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 5, 2023

[jans-core] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 5, 2023

[SCIM API] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 5, 2023

[jans-config-api-parent] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 5, 2023

[Jans authentication server parent] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Milton-Ch Milton-Ch force-pushed the feat/mds-and-attestation-optional branch from da0e996 to 3e7dab1 Compare July 5, 2023 14:54
@Milton-Ch Milton-Ch force-pushed the feat/mds-and-attestation-optional branch 3 times, most recently from a6ece8a to 86971ad Compare July 15, 2023 03:05
@Milton-Ch Milton-Ch force-pushed the feat/mds-and-attestation-optional branch from 86971ad to 9a72238 Compare July 21, 2023 14:08
nynymike
nynymike reviewed Jul 21, 2023
View reviewed changes
Copy link
Contributor

@nynymike nynymike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a property for this feature? Are there updates to the docs so people know how to use this feature?

@Milton-Ch Milton-Ch force-pushed the feat/mds-and-attestation-optional branch from 19770ff to 7219a56 Compare July 26, 2023 09:02
@Milton-Ch Milton-Ch force-pushed the feat/mds-and-attestation-optional branch 2 times, most recently from 3347494 to e3b07f1 Compare August 31, 2023 17:07
@Milton-Ch
feat(jans-fido2): mds optional
b753592 
Signed-off-by: Milton Ch. <j.milton.chambi.m@gmail.com>
@Milton-Ch Milton-Ch force-pushed the feat/mds-and-attestation-optional branch from e3b07f1 to b753592 Compare August 31, 2023 17:50
@Milton-Ch Milton-Ch marked this pull request as ready for review September 1, 2023 00:53
@yurem yurem merged commit fad9961 into main Sep 1, 2023
@yurem yurem deleted the feat/mds-and-attestation-optional branch September 1, 2023 16:58
@mo-auto mo-auto mentioned this pull request Sep 17, 2023
Merged
@mo-auto3 mo-auto3 mentioned this pull request Sep 17, 2023
Merged
@mo-auto mo-auto mentioned this pull request Sep 17, 2023
Merged
devrimyatar pushed a commit that referenced this pull request Dec 30, 2023
@Milton-Ch @devrimyatar
feat(jans-fido2): mds optional (#5409)
19a17dc 
Signed-off-by: Milton Ch. <j.milton.chambi.m@gmail.com>
Signed-off-by: Mustafa Baser <mbaser@mail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nynymike nynymike nynymike left review comments

@yurem yurem yurem approved these changes

@devrimyatar devrimyatar Awaiting requested review from devrimyatar devrimyatar is a code owner

@smansoft smansoft Awaiting requested review from smansoft

@yuriyz yuriyz Awaiting requested review from yuriyz yuriyz is a code owner

Assignees
No one assigned
Labels
comp-jans-fido2 Component affected by issue or PR kind-feature Issue or PR is a new feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(jans-fido2): Make MDS and attestation optional
4 participants
@Milton-Ch @nynymike @yurem @mo-auto