Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(fido2): Exception handling for assertion #5689

Merged
merged 4 commits into from
Aug 15, 2023
Merged

Fix(fido2): Exception handling for assertion #5689

merged 4 commits into from
Aug 15, 2023

Conversation

Milton-Ch
Copy link
Contributor

Prepare

Description

  • Migrating exception handler from jans-auth to jans-fido2
  • Changed all the exceptions to the endpoint /assertion
  • Changes in jans-linux-setup to load errors in configuration table

closes #3902

@mo-auto mo-auto added comp-jans-auth-server Component affected by issue or PR comp-jans-core Component affected by issue or PR comp-jans-fido2 Component affected by issue or PR comp-jans-linux-setup Component affected by issue or PR labels Jul 29, 2023
@sonarqubecloud
Copy link

[jans-core] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Milton-Ch Milton-Ch force-pushed the fix/exception-handle branch from 146b3b7 to c18dc36 Compare July 29, 2023 03:04
@sonarqubecloud
Copy link

[Jans authentication server parent] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Milton-Ch Milton-Ch force-pushed the fix/exception-handle branch from c18dc36 to 5b97dab Compare July 31, 2023 20:43
@sonarqubecloud
Copy link

[jans-linux-setup] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@Milton-Ch Milton-Ch marked this pull request as ready for review August 15, 2023 02:31
@sonarqubecloud
Copy link

[Fido2 API] SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 189 Code Smells

0.0% 0.0% Coverage
2.5% 2.5% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@yurem yurem merged commit 2c82c5d into main Aug 15, 2023
@yurem yurem deleted the fix/exception-handle branch August 15, 2023 13:40
@mo-auto3 mo-auto3 mentioned this pull request Sep 17, 2023
Merged
@mo-auto mo-auto mentioned this pull request Sep 17, 2023
Merged
devrimyatar pushed a commit that referenced this pull request Dec 30, 2023
@Milton-Ch @devrimyatar
Fix(fido2): Exception handling for assertion (#5689)
25ec592 
* fix(fido2): exception handler for /assertion endpoint

* fix(fido2): exception handler for /attestation endpoint

* fix(fido2): added unit test for AssertionController, AttestationController and ConfigurationController

* fix(fido2): added unit test for android key and android safetynet processors

Signed-off-by: Mustafa Baser <mbaser@mail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yurem yurem yurem approved these changes

@devrimyatar devrimyatar devrimyatar approved these changes

@smansoft smansoft Awaiting requested review from smansoft

@yuriyz yuriyz Awaiting requested review from yuriyz yuriyz is a code owner

Assignees
No one assigned
Labels
comp-jans-auth-server Component affected by issue or PR comp-jans-core Component affected by issue or PR comp-jans-fido2 Component affected by issue or PR comp-jans-linux-setup Component affected by issue or PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix(jans-fido2): Exception handling for endpoints
4 participants
@Milton-Ch @yurem @devrimyatar @mo-auto