Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(docker-jans-persistence-loader): reusable assets for custom image #5792

Merged
merged 1 commit into from
Aug 9, 2023

Conversation

iromli
Copy link
Contributor

@iromli iromli commented Aug 4, 2023

Prepare


Description

Target issue

closes #5791

Implementation Details

Point 1: change logger prefix to persistence-loader

The prefix of entrypoint has been changed from:

INFO - entrypoint - 2023-08-04 18:02:33,256 - Creating tables (if not exist)
INFO - entrypoint - 2023-08-04 18:02:33,327 - Updating schema (if required)
INFO - entrypoint - 2023-08-04 18:02:33,461 - Creating indexes (if not exist)
INFO - entrypoint - 2023-08-04 18:02:33,676 - Importing builtin LDIF files

to

INFO - persistence-loader - 2023-08-04 18:02:33,256 - Creating tables (if not exist)
INFO - persistence-loader - 2023-08-04 18:02:33,327 - Updating schema (if required)
INFO - persistence-loader - 2023-08-04 18:02:33,461 - Creating indexes (if not exist)
INFO - persistence-loader - 2023-08-04 18:02:33,676 - Importing builtin LDIF files

Point no. 2: allow executing entrypoint.sh from any directory or by using symlink

The entrypoint.sh can be executed from any directory. Also it support symlink, for example:

ln -s /app/scripts/entrypoint.sh /app/bin/persistence-loader-entrypoint.sh
sh /app/bin/persistence-loader-entrypoint.sh

Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

@iromli iromli requested a review from moabu as a code owner August 4, 2023 18:07
@mo-auto mo-auto added comp-docker-jans-persistence-loader kind-enhancement Issue or PR is an enhancement to an existing functionality labels Aug 4, 2023
@moabu moabu merged commit 7bab249 into main Aug 9, 2023
@moabu moabu deleted the cn-persistence-reusable branch August 9, 2023 07:04
devrimyatar pushed a commit that referenced this pull request Dec 30, 2023
…image (#5792)

Signed-off-by: Mustafa Baser <mbaser@mail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp-docker-jans-persistence-loader kind-enhancement Issue or PR is an enhancement to an existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor(docker-jans-persistence-loader): reusable assets for custom image
3 participants