Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(docker-jans): allow passing initial keys expiration time #7850

Merged
merged 1 commit into from
Feb 26, 2024
Merged

feat(docker-jans): allow passing initial keys expiration time #7850

merged 1 commit into from
Feb 26, 2024

Conversation

iromli
Copy link
Contributor

@iromli iromli commented Feb 26, 2024 •
edited
Loading

Prepare

Description

Target issue

closes #7833

Implementation Details

Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

@iromli
feat(docker-jans): allow passing initial keys expiration time
28886fb 
Signed-off-by: iromli <isman.firmansyah@gmail.com>
@iromli iromli requested a review from moabu as a code owner February 26, 2024 18:17
@mo-auto mo-auto added area-documentation Documentation needs to change as part of issue or PR comp-charts-jans comp-docker-jans-all-in-one Touching folder /docker-jans-all-in-one comp-docker-jans-configurator kind-feature Issue or PR is a new feature request labels Feb 26, 2024
@moabu moabu merged commit 0f6dfa3 into main Feb 26, 2024
2 checks passed
@moabu moabu deleted the cn-init-keys-exp branch February 26, 2024 19:31
devrimyatar pushed a commit that referenced this pull request Feb 27, 2024
@iromli @devrimyatar
feat(docker-jans): allow passing initial keys expiration time (#7850)
68fbd20 
Signed-off-by: iromli <isman.firmansyah@gmail.com>
Signed-off-by: Mustafa Baser <mbaser@mail.com>
yuriyz pushed a commit that referenced this pull request Nov 7, 2024
@iromli
feat(docker-jans): allow passing initial keys expiration time (#7850)
2b7446d 
Signed-off-by: iromli <isman.firmansyah@gmail.com>
Former-commit-id: 0f6dfa3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moabu moabu moabu approved these changes

Assignees
No one assigned
Labels
area-documentation Documentation needs to change as part of issue or PR comp-charts-jans comp-docker-jans-all-in-one Touching folder /docker-jans-all-in-one comp-docker-jans-configurator kind-feature Issue or PR is a new feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(docker-jans): allow passing initial keys expiration time
3 participants
@iromli @moabu @mo-auto