Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(jans-fido2): add new unit test for processor.assertion #7854

Merged
merged 2 commits into from
Feb 28, 2024
Merged

feat(jans-fido2): add new unit test for processor.assertion #7854

merged 2 commits into from
Feb 28, 2024

Conversation

Milton-Ch
Copy link
Contributor

Prepare

Description

Target issue

closes #4903

Implementation Details

  • All unit tests for processor.assertion have been completed.

Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

@Milton-Ch
feat(jans-fido2): add new unit test for assertion
ff8b300 
Signed-off-by: Milton Ch <j.milton.chambi.m@gmail.com>
@Milton-Ch Milton-Ch requested a review from yurem as a code owner February 27, 2024 03:25
@Milton-Ch Milton-Ch requested a review from moabu February 27, 2024 03:26
@mo-auto mo-auto added comp-jans-fido2 Component affected by issue or PR kind-feature Issue or PR is a new feature request labels Feb 27, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed for 'Fido2 API'

Failed conditions
48 New Code Smells (required ≤ 8)
35 Duplicated Lines on New Code (required ≤ 20)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

@yurem yurem enabled auto-merge (squash) February 28, 2024 11:22
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'jans-linux-setup'

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'Jans lock server parent'

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'jans-config-api-parent'

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@Milton-Ch Milton-Ch requested a review from yuriyz February 28, 2024 12:26
@yurem yurem merged commit 232f808 into main Feb 28, 2024
5 checks passed
@yurem yurem deleted the feat/unit-test-assertions branch February 28, 2024 12:28
yuriyz pushed a commit that referenced this pull request Nov 7, 2024
@Milton-Ch
feat(jans-fido2): add new unit test for assertion (#7854)
de3bcf5 
Signed-off-by: Milton Ch <j.milton.chambi.m@gmail.com>
Former-commit-id: 232f808
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yurem yurem yurem approved these changes

@moabu moabu moabu approved these changes

@yuriyz yuriyz Awaiting requested review from yuriyz

Assignees
No one assigned
Labels
comp-jans-fido2 Component affected by issue or PR kind-feature Issue or PR is a new feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: Unit test for the io.jans.fido2.service.processor package
4 participants
@Milton-Ch @yurem @moabu @mo-auto