fix(keycloak-integration): saml metadata parsing #7777 #7862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* added saml xsd metadata * added www.w3.org metadata Signed-off-by: Rolain Djeumen <uprightech@gmail.com>
* added ContactPerson metadata object * added Endpoint and IndexEndpoint metadata object Signed-off-by: Rolain Djeumen <uprightech@gmail.com>
* added EntityDescriptor metadata object Signed-off-by: Rolain Djeumen <uprightech@gmail.com>
* added SPSSODescriptor metadata object * added SSODescriptor metadata object * added RoleDescriptor metadata object Signed-off-by: Rolain Djeumen <uprightech@gmail.com>
* added SAMLMetadata wrapper object Signed-off-by: Rolain Djeumen <uprightech@gmail.com>
* added KeyDescriptor metadata object * added Localizedtext metadata object * added Organization metadata object Signed-off-by: Rolain Djeumen <uprightech@gmail.com>
* added various digital signature models Signed-off-by: Rolain Djeumen <uprightech@gmail.com>
* added xml encryption objects Signed-off-by: Rolain Djeumen <uprightech@gmail.com>
* housekeeping for schema directories Signed-off-by: Rolain Djeumen <uprightech@gmail.com>
* added various utility classes to support metadata parsing Signed-off-by: Rolain Djeumen <uprightech@gmail.com>
* added builder for SAMLMetadata Signed-off-by: Rolain Djeumen <uprightech@gmail.com>
* added EndpointBuilder helper * added IndexedEndpointBuilder helper Signed-off-by: Rolain Djeumen <uprightech@gmail.com>
* added EntityDescriptorBuilder helper Signed-off-by: Rolain Djeumen <uprightech@gmail.com>
* added ContactPersonBuilder * added EndpointBuilder * added IndexedEndpointBuilder * added KeyDescriptorBuilder * added LocalizedTextBuilder * added OrganizationBuilder Signed-off-by: Rolain Djeumen <uprightech@gmail.com>
* added RoleDescriptorBuilder * added SSODescriptorBuilder * added SPSSODescriptorBuilder Signed-off-by: Rolain Djeumen <uprightech@gmail.com>
Signed-off-by: Rolain Djeumen <uprightech@gmail.com>
Signed-off-by: Rolain Djeumen <uprightech@gmail.com>
mo-auto
added
comp-jans-core
* removed debugging statement from XPathUtils Signed-off-by: Rolain Djeumen <uprightech@gmail.com>
yuriyz
requested changes
Feb 27, 2024
| public LocalizedText() { | ||
|
|
||
| this.language = language; | ||
| this.text = text; |
There was a problem hiding this comment.
Is this code auto-generated? Otherwise it's not clear what code above means. Empty constructor with assigning variables to itself.
Also when I look on all these boilderplate builders from "io.jans.saml.metadata.builder" package I think about lombok. If we plan to heavily rely on builders maybe it's good time to add lombok to not waste time on builders in future.
There was a problem hiding this comment.
@yuriyz this has been fixed. Could you please accept the changes ?
* renamed method in EntityDescriptorBuilder Signed-off-by: Rolain Djeumen <uprightech@gmail.com>
* minor changes to RoleDescriptorBuilder Signed-off-by: Rolain Djeumen <uprightech@gmail.com>
*minor changes to SAMLMetadataBuilder Signed-off-by: Rolain Djeumen <uprightech@gmail.com>
*minor changes to SPSSODescriptorBuilder Signed-off-by: Rolain Djeumen <uprightech@gmail.com>
* minor changes to SSODescriptorBuilder Signed-off-by: Rolain Djeumen <uprightech@gmail.com>
Signed-off-by: Rolain Djeumen <uprightech@gmail.com>
* adjustments related to code quality Signed-off-by: Rolain Djeumen <uprightech@gmail.com>
Signed-off-by: Rolain Djeumen <uprightech@gmail.com>
Signed-off-by: Rolain Djeumen <uprightech@gmail.com>
Signed-off-by: Rolain Djeumen <uprightech@gmail.com>
Signed-off-by: Rolain Djeumen <uprightech@gmail.com>
moabu
approved these changes
Feb 28, 2024
|
|
|
|
|
|
|
|
|
|
yuriyz
approved these changes
Mar 8, 2024
yuriyz
pushed a commit
that referenced
this pull request
Nov 7, 2024
* fix(keycloak-integration): saml metadata parsing #7777 * added saml xsd metadata * added www.w3.org metadata Signed-off-by: Rolain Djeumen <uprightech@gmail.com> * fix(keycloak-integration): saml metadata parsing #7777 * added ContactPerson metadata object * added Endpoint and IndexEndpoint metadata object Signed-off-by: Rolain Djeumen <uprightech@gmail.com> * fix(keycloak-integration): saml metadata parsing #7777 * added EntityDescriptor metadata object Signed-off-by: Rolain Djeumen <uprightech@gmail.com> * fix(keycloak-integration): saml metadata parsing #7777 * added SPSSODescriptor metadata object * added SSODescriptor metadata object * added RoleDescriptor metadata object Signed-off-by: Rolain Djeumen <uprightech@gmail.com> * fix(keycloak-integration): saml metadata parsing #7777 * added SAMLMetadata wrapper object Signed-off-by: Rolain Djeumen <uprightech@gmail.com> * fix(keycloak-integration): saml metadata parsing #7777 * added KeyDescriptor metadata object * added Localizedtext metadata object * added Organization metadata object Signed-off-by: Rolain Djeumen <uprightech@gmail.com> * fix(keycloak-integration): saml metadata parsing #7777 * added various digital signature models Signed-off-by: Rolain Djeumen <uprightech@gmail.com> * fix(keycloak-integration): saml metadata parsing #7777 * added xml encryption objects Signed-off-by: Rolain Djeumen <uprightech@gmail.com> * fix(keycloak-integration): saml metadata parser #7777 * housekeeping for schema directories Signed-off-by: Rolain Djeumen <uprightech@gmail.com> * fix(keycloak-integration): saml metadata parsing #7777 * added various utility classes to support metadata parsing Signed-off-by: Rolain Djeumen <uprightech@gmail.com> * fix(keycloak-integration): saml metadata parsing #7777 * added builder for SAMLMetadata Signed-off-by: Rolain Djeumen <uprightech@gmail.com> * fix(keycloak-integration): saml metadata parsing #7777 * added EndpointBuilder helper * added IndexedEndpointBuilder helper Signed-off-by: Rolain Djeumen <uprightech@gmail.com> * fix(keycloak-integration): saml metadata parsing #7777 * added EntityDescriptorBuilder helper Signed-off-by: Rolain Djeumen <uprightech@gmail.com> * fix(keycloak-integration): saml metadata parsing #7777 * added ContactPersonBuilder * added EndpointBuilder * added IndexedEndpointBuilder * added KeyDescriptorBuilder * added LocalizedTextBuilder * added OrganizationBuilder Signed-off-by: Rolain Djeumen <uprightech@gmail.com> * fix(keycloak-integration): saml metadata parsing #7777 * added RoleDescriptorBuilder * added SSODescriptorBuilder * added SPSSODescriptorBuilder Signed-off-by: Rolain Djeumen <uprightech@gmail.com> * fix(keycloak-integration): saml metatata parsing #7777 Signed-off-by: Rolain Djeumen <uprightech@gmail.com> * fix(keycloak-integration): saml metadata parsing #7777 Signed-off-by: Rolain Djeumen <uprightech@gmail.com> * fix(keycloak-integration): saml metadata parsing #7777 * removed debugging statement from XPathUtils Signed-off-by: Rolain Djeumen <uprightech@gmail.com> * fix(keycloak-integration): saml metadata parsing #7777 * renamed method in EntityDescriptorBuilder Signed-off-by: Rolain Djeumen <uprightech@gmail.com> * fix(keycloak-integration): saml metadata parsing #7777 * minor changes to RoleDescriptorBuilder Signed-off-by: Rolain Djeumen <uprightech@gmail.com> * fix(keycloak-integration): saml metadata parsing #7777 *minor changes to SAMLMetadataBuilder Signed-off-by: Rolain Djeumen <uprightech@gmail.com> * fix(keycloak-integration): saml metadata parsing #7777 *minor changes to SPSSODescriptorBuilder Signed-off-by: Rolain Djeumen <uprightech@gmail.com> * fix(keycloak-integration): saml metadata parsing #7777 * minor changes to SSODescriptorBuilder Signed-off-by: Rolain Djeumen <uprightech@gmail.com> * fix(keycloak-integration): saml metadata parsing #7777 Signed-off-by: Rolain Djeumen <uprightech@gmail.com> * fix(keycloak-integration): saml metadata parsing #7777 * adjustments related to code quality Signed-off-by: Rolain Djeumen <uprightech@gmail.com> * fix(keycloak-integration): saml metadata parsing #7777 Signed-off-by: Rolain Djeumen <uprightech@gmail.com> * fix(keycloak-integration): saml metadata parser #7777 Signed-off-by: Rolain Djeumen <uprightech@gmail.com> * fix(keycloak-integration): saml metadata parser #7777 Signed-off-by: Rolain Djeumen <uprightech@gmail.com> * fix(keycloak-integration): saml metadata parsing #7777 Signed-off-by: Rolain Djeumen <uprightech@gmail.com> --------- Signed-off-by: Rolain Djeumen <uprightech@gmail.com> Co-authored-by: Mohammad Abudayyeh <47318409+moabu@users.noreply.github.com> Former-commit-id: 53ef338
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue is in fullfillment for issue #7777 .
There is a duplication of saml metadata parser classes which will be resolved in subsequent versions.