Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(database): add instructions for passing DB properties dynamically #7888

Merged
merged 6 commits into from
Mar 1, 2024

Conversation

ossdhaval
Copy link
Contributor

Prepare


Description

Target issue

closes #7408

Implementation Details


Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

Signed-off-by: ossdhaval <343411+ossdhaval@users.noreply.github.com>
Signed-off-by: ossdhaval <343411+ossdhaval@users.noreply.github.com>
Signed-off-by: ossdhaval <343411+ossdhaval@users.noreply.github.com>
Signed-off-by: ossdhaval <343411+ossdhaval@users.noreply.github.com>
@ossdhaval ossdhaval added the area-documentation Documentation needs to change as part of issue or PR label Feb 28, 2024
@ossdhaval ossdhaval added this to the 1.1.0 milestone Feb 28, 2024
@ossdhaval ossdhaval requested a review from moabu February 28, 2024 19:46
@ossdhaval ossdhaval self-assigned this Feb 28, 2024
@mo-auto mo-auto enabled auto-merge (squash) February 28, 2024 19:53
mo-auto
mo-auto previously approved these changes Feb 28, 2024
@ossdhaval ossdhaval requested a review from iromli February 29, 2024 14:32
- Override connection URI for one specific component. For instance,
`jans-auth` component
```shell
CN_AUTH_JAVA_OPTIONS=-Dconnection.uri=new-mysql-uri
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can use jdbc:postgresql://postgresql.sql.svc.cluster.local:5432/jansdb for example of connection URI.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iromli These changes have been added by Mo in the subsequent commit.

@mo-auto mo-auto merged commit 644b74d into main Mar 1, 2024
2 checks passed
@mo-auto mo-auto deleted the docs-db-prop-override branch March 1, 2024 12:23
yuriyz pushed a commit that referenced this pull request Nov 7, 2024
#7888)

* fix(docs): add property override for VM

Signed-off-by: ossdhaval <343411+ossdhaval@users.noreply.github.com>

* fix(docs): add property override instructions for CN

Signed-off-by: ossdhaval <343411+ossdhaval@users.noreply.github.com>

* fix(docs): minor updates

Signed-off-by: ossdhaval <343411+ossdhaval@users.noreply.github.com>

* fix(docs): proofreading changes

Signed-off-by: ossdhaval <343411+ossdhaval@users.noreply.github.com>

* docs(chart): add helm instructions

---------

Signed-off-by: ossdhaval <343411+ossdhaval@users.noreply.github.com>
Co-authored-by: Mohammad Abudayyeh <47318409+moabu@users.noreply.github.com>
Former-commit-id: 644b74d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-documentation Documentation needs to change as part of issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs(jans): allow for passing db properties dynamically
4 participants