Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add feature to allow registration of multiple clients #7725 #7934

Merged
merged 5 commits into from
Mar 4, 2024
Merged

feat: add feature to allow registration of multiple clients #7725 #7934

merged 5 commits into from
Mar 4, 2024

Conversation

duttarnab
Copy link
Contributor

closes #7725

@duttarnab
feat: add feature to allow registration of multiple clients #7725
1db8386 
Signed-off-by: Arnab Dutta <arnab.bdutta@gmail.com>
@mo-auto mo-auto added the kind-feature Issue or PR is a new feature request label Mar 3, 2024
jv18creator
jv18creator suggested changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@jv18creator jv18creator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please have a look at the inline comments.

duttarnab added 3 commits March 4, 2024 13:15
@duttarnab
feat: close review comments
35d302b 
Signed-off-by: Arnab Dutta <arnab.bdutta@gmail.com>
@duttarnab
fix: remove error in create tarp build
f85e244 
Signed-off-by: Arnab Dutta <arnab.bdutta@gmail.com>
@duttarnab
feat: remove package-lock json
c22e1ba 
Signed-off-by: Arnab Dutta <arnab.bdutta@gmail.com>
@moabu moabu merged commit afc6f39 into main Mar 4, 2024
2 checks passed
@moabu moabu deleted the jans-tarp-issue-7725 branch March 4, 2024 11:44
yuriyz pushed a commit that referenced this pull request Nov 7, 2024
@duttarnab @moabu
feat: add feature to allow registration of multiple clients #7725 (#7934
d454d5a 
)

* feat: add feature to allow registration of multiple clients #7725

Signed-off-by: Arnab Dutta <arnab.bdutta@gmail.com>

* feat: close review comments

Signed-off-by: Arnab Dutta <arnab.bdutta@gmail.com>

* fix: remove error in create tarp build

Signed-off-by: Arnab Dutta <arnab.bdutta@gmail.com>

* feat: remove package-lock json

Signed-off-by: Arnab Dutta <arnab.bdutta@gmail.com>

---------

Signed-off-by: Arnab Dutta <arnab.bdutta@gmail.com>
Co-authored-by: Mohammad Abudayyeh <47318409+moabu@users.noreply.github.com>
Former-commit-id: afc6f39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jv18creator jv18creator jv18creator requested changes

@moabu moabu moabu approved these changes

Assignees
No one assigned
Labels
kind-feature Issue or PR is a new feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(jans-tarp): add feature to allow registration of multiple clients
4 participants
@duttarnab @moabu @jv18creator @mo-auto