Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make loggers static fields #7949

Merged
merged 2 commits into from
Mar 5, 2024
Merged

fix: make loggers static fields #7949

merged 2 commits into from
Mar 5, 2024

Conversation

jgomer2001
Copy link
Contributor

Prepare

Description

Target issue

closes #7948

Implementation Details

Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

@jgomer2001
fix: make loggers static fields #7948
7327cb5 
Signed-off-by: jgomer2001 <bonustrack310@gmail.com>
@mo-auto mo-auto added area-documentation Documentation needs to change as part of issue or PR comp-jans-auth-server Component affected by issue or PR comp-agama Touching folder /agama kind-bug Issue or PR is a bug in existing functionality labels Mar 4, 2024
@yuriyz yuriyz enabled auto-merge (squash) March 5, 2024 05:33
@moabu moabu disabled auto-merge March 5, 2024 08:05
@moabu moabu merged commit bc1e004 into main Mar 5, 2024
2 checks passed
@moabu moabu deleted the agama-issue_7948 branch March 5, 2024 08:05
yuriyz pushed a commit that referenced this pull request Nov 7, 2024
@jgomer2001 @moabu
fix: make loggers static fields #7948 (#7949)
1681df4 
Signed-off-by: jgomer2001 <bonustrack310@gmail.com>
Co-authored-by: Mohammad Abudayyeh <47318409+moabu@users.noreply.github.com>
Former-commit-id: bc1e004
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuriyz yuriyz yuriyz approved these changes

@moabu moabu moabu approved these changes

@maduvena maduvena Awaiting requested review from maduvena maduvena is a code owner

@yurem yurem Awaiting requested review from yurem yurem is a code owner

Assignees
No one assigned
Labels
area-documentation Documentation needs to change as part of issue or PR comp-agama Touching folder /agama comp-jans-auth-server Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix(agama-inbound): serialization errors in agama inbound identity project
4 participants
@jgomer2001 @yuriyz @moabu @mo-auto