Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(config-api) code optimization and SMAL IDP delete scope rectification #8022

Merged
merged 15 commits into from
Mar 12, 2024
Merged

fix(config-api) code optimization and SMAL IDP delete scope rectification #8022

merged 15 commits into from
Mar 12, 2024

Conversation

pujavs
Copy link
Contributor

@pujavs pujavs commented Mar 11, 2024 •
edited
Loading

Prepare

Description

Target issue

closes #8021 #8031

Implementation Details

Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

pujavs added 10 commits March 6, 2024 22:02
@pujavs
fix(config-api): user attribute validation and SAML TR update file na…
7a6f830 
…me fix

Signed-off-by: pujavs <pujas.works@gmail.com>
@pujavs
fix(config-api): user mgmt added search filter for givenName, middleN…
fc093b1 
…ame, nickName and sn

Signed-off-by: pujavs <pujas.works@gmail.com>
@pujavs
fix(config-api): user mgmt validation for custom attributes
6cc746f 
Signed-off-by: pujavs <pujas.works@gmail.com>
@pujavs
Merge branch 'main' of https://github.com/JanssenProject/jans into ja…
01f3698 
…ns-config-api-fixes
@pujavs
fix(config-api): sysnc with main
d24d535 
Signed-off-by: pujavs <pujas.works@gmail.com>
@pujavs
fix(config-api): sysnc with main
02be670 
Signed-off-by: pujavs <pujas.works@gmail.com>
@pujavs
Merge branch 'main' of https://github.com/JanssenProject/jans into ja…
3bcffbf 
…ns-config-api-fixes
@pujavs
feat(config-api): SAML TR removing chk for metadata file on update
746667b 
Signed-off-by: pujavs <pujas.works@gmail.com>
@pujavs
Merge branch 'main' of https://github.com/JanssenProject/jans into ja…
4a2b48e 
…ns-config-api-fixes
@pujavs
fix(config-api): out of memory issue 8021
1e223d0 
Signed-off-by: pujavs <pujas.works@gmail.com>
@pujavs pujavs requested review from yuriyz and yurem as code owners March 11, 2024 17:43
@pujavs pujavs requested a review from moabu March 11, 2024 18:07
moabu
moabu previously approved these changes Mar 11, 2024
View reviewed changes
yuriyz
yuriyz previously approved these changes Mar 11, 2024
View reviewed changes
@pujavs pujavs enabled auto-merge (squash) March 12, 2024 06:56
pujavs and others added 2 commits March 12, 2024 12:45
@pujavs
feat(config-api): sync with main
fb05b5f 
Signed-off-by: pujavs <pujas.works@gmail.com>
@pujavs
Merge branch 'main' into jans-config-api-fixes
cae73aa 
Signed-off-by: pujavs <43700552+pujavs@users.noreply.github.com>
@pujavs pujavs dismissed stale reviews from yuriyz and moabu via cae73aa March 12, 2024 09:18
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'jans-cli'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'jans-pycloudlib'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'jans-linux-setup'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'orm'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'jans-core'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

pujavs added 2 commits March 12, 2024 15:19
@pujavs
fix(config-api) saml IDP delete scope issue#8031
9945851 
Signed-off-by: pujavs <pujas.works@gmail.com>
@pujavs
fix(config-api) saml IDP delete scope issue#8031
68ffced 
Signed-off-by: pujavs <pujas.works@gmail.com>
@pujavs pujavs requested review from moabu and yuriyz March 12, 2024 11:28
@pujavs pujavs changed the title fix(config-api) out of memory issue fix(config-api) out of memory issue and SMAL IDP delete scope rectification Mar 12, 2024
@mo-auto mo-auto added comp-jans-config-api Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality labels Mar 12, 2024
@pujavs pujavs changed the title fix(config-api) out of memory issue and SMAL IDP delete scope rectification fix(config-api) code optimization and SMAL IDP delete scope rectification Mar 12, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'Jans-Keycloak-Link'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'jans-config-api-parent'

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@moabu moabu disabled auto-merge March 12, 2024 11:38
@moabu moabu merged commit 679c8b9 into main Mar 12, 2024
4 checks passed
@moabu moabu deleted the jans-config-api-fixes branch March 12, 2024 11:39
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'SCIM API'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'Fido2 API'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@pujavs pujavs mentioned this pull request Mar 20, 2024
Closed
yuriyz pushed a commit that referenced this pull request Nov 7, 2024
@pujavs
fix(config-api) code optimization and SMAL IDP delete scope rectifica…
caa376c 
…tion (#8022)

* fix(config-api): user attribute validation and SAML TR update file name fix

Signed-off-by: pujavs <pujas.works@gmail.com>

* fix(config-api): user mgmt added search filter for givenName, middleName, nickName and sn

Signed-off-by: pujavs <pujas.works@gmail.com>

* fix(config-api): user mgmt validation for custom attributes

Signed-off-by: pujavs <pujas.works@gmail.com>

* fix(config-api): sysnc with main

Signed-off-by: pujavs <pujas.works@gmail.com>

* fix(config-api): sysnc with main

Signed-off-by: pujavs <pujas.works@gmail.com>

* feat(config-api): SAML TR removing chk for metadata file on update

Signed-off-by: pujavs <pujas.works@gmail.com>

* fix(config-api): out of memory issue 8021

Signed-off-by: pujavs <pujas.works@gmail.com>

* fix(config-api) saml IDP delete scope issue#8031

Signed-off-by: pujavs <pujas.works@gmail.com>

---------

Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <43700552+pujavs@users.noreply.github.com>
Former-commit-id: 679c8b9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moabu moabu moabu approved these changes

@yurem yurem Awaiting requested review from yurem yurem is a code owner

@yuriyz yuriyz Awaiting requested review from yuriyz yuriyz is a code owner

Assignees
No one assigned
Labels
comp-jans-config-api Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix(config-api): Out of memory issue
4 participants
@pujavs @yuriyz @moabu @mo-auto