Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docker): allow custom sql_data_types #8049

Merged
merged 2 commits into from
Mar 14, 2024
Merged

Conversation

iromli
Copy link
Contributor

@iromli iromli commented Mar 13, 2024

Prepare


Description

Target issue

closes #8048

Implementation Details


Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

Signed-off-by: iromli <isman.firmansyah@gmail.com>
@iromli iromli requested a review from moabu as a code owner March 13, 2024 19:20
@mo-auto mo-auto added comp-jans-pycloudlib kind-feature Issue or PR is a new feature request labels Mar 13, 2024
Copy link

codecov bot commented Mar 13, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (main@54beb14). Click here to learn what that means.

❗ Current head 919f8b7 differs from pull request most recent head 5e3636d. Consider uploading reports for the commit 5e3636d to get more accurate results

Files Patch % Lines
jans-pycloudlib/jans/pycloudlib/persistence/sql.py 71.42% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8049   +/-   ##
=======================================
  Coverage        ?   60.42%           
=======================================
  Files           ?       36           
  Lines           ?     3171           
  Branches        ?        0           
=======================================
  Hits            ?     1916           
  Misses          ?     1255           
  Partials        ?        0           
Flag Coverage Δ
unittests 60.42% <71.42%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@moabu moabu merged commit 3a61685 into main Mar 14, 2024
2 checks passed
@moabu moabu deleted the cn-sql-datatype-override branch March 14, 2024 09:39
Copy link

Quality Gate Passed Quality Gate passed for 'Jans-Keycloak-Link'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

Quality Gate Passed Quality Gate passed for 'Jans lock server parent'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

yuriyz pushed a commit that referenced this pull request Nov 7, 2024
Signed-off-by: iromli <isman.firmansyah@gmail.com>
Co-authored-by: Mohammad Abudayyeh <47318409+moabu@users.noreply.github.com>
Former-commit-id: 3a61685
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp-jans-pycloudlib kind-feature Issue or PR is a new feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(docker): allow custom sql_data_types
3 participants