-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(jans-cli-tui): config-api configuration #9127
Conversation
Signed-off-by: Mustafa Baser <mbaser@mail.com>
DryRun Security SummaryThe pull request covers various updates to the Jans CLI-TUI application, including improvements to the handling of list-type values, Admin UI functionality, documentation for the Jans Config-API configuration, and enhancements to utility functions and user interface components, with a focus on ensuring the overall security of the application. Expand for full summarySummary: The code changes in this pull request cover various aspects of the Jans CLI-TUI application, including updates to the handling of list-type values in the From an application security perspective, the changes do not appear to introduce any obvious security vulnerabilities. However, it is important to review the entire codebase and the application's architecture to ensure that it follows best practices for secure application development. Key areas to focus on include input validation, authentication and authorization, logging and auditing, secure communication, and the handling of sensitive data. The documentation updates for the Jans Config-API configuration are particularly noteworthy, as they highlight several security-related settings and controls, such as API protection, CORS configuration, audit logging, and user attribute validation. These settings are critical for ensuring the overall security of the application. Files Changed:
Code AnalysisWe ran Riskiness🟢 Risk threshold not exceeded. |
Hi @devrimyatar Thanks for high-lighting the need for update to the documentation for this PR. There are two things that I can suggest. And these are what we are striving to achieve too with respect to how we tackle the documentation.
Both of the above points will help us keep up the documentation with the constantly evolving code and the Janssen Server's feature set. For this PR, mention me in the PR comments once you add the documentation that is ready for review. |
Signed-off-by: Mustafa Baser <mbaser@mail.com>
Signed-off-by: Mustafa Baser <mbaser@mail.com>
Signed-off-by: Mustafa Baser <mbaser@mail.com>
|
|
|
|
|
|
|
|
|
There is this document that has a good amount of overlap with your document. I'll need to merge contents. |
Signed-off-by: ossdhaval <343411+ossdhaval@users.noreply.github.com>
Signed-off-by: ossdhaval <343411+ossdhaval@users.noreply.github.com>
Signed-off-by: ossdhaval <343411+ossdhaval@users.noreply.github.com>
|
|
* feat(jans-cli-tui): config-api configuration Signed-off-by: Mustafa Baser <mbaser@mail.com> * fix(jans-cli-tui): display save info on dialog for config-api config Signed-off-by: Mustafa Baser <mbaser@mail.com> * docs(jans-cli-tui): config-api configuratios Signed-off-by: Mustafa Baser <mbaser@mail.com> * docs(jans-cli-tui): config-api swagger reference Signed-off-by: Mustafa Baser <mbaser@mail.com> * docs(config-api): update config api Signed-off-by: ossdhaval <343411+ossdhaval@users.noreply.github.com> * docs: edit the update section Signed-off-by: ossdhaval <343411+ossdhaval@users.noreply.github.com> * docs: proofreading changes Signed-off-by: ossdhaval <343411+ossdhaval@users.noreply.github.com> --------- Signed-off-by: Mustafa Baser <mbaser@mail.com> Signed-off-by: ossdhaval <343411+ossdhaval@users.noreply.github.com> Co-authored-by: ossdhaval <343411+ossdhaval@users.noreply.github.com> Former-commit-id: bdf5707
closes #8598
@ossdhaval This PR needs TUI documentation update. After this PR merged please update TUI docs and add Config API screen: