Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cloud-native): sync assets for OCI images #9261

Merged
merged 6 commits into from
Aug 27, 2024
Merged

chore(cloud-native): sync assets for OCI images #9261

merged 6 commits into from
Aug 27, 2024

Conversation

iromli
Copy link
Contributor

@iromli iromli commented Aug 23, 2024

Prepare


Description

Target issue

closes #9260

Implementation Details


Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

Please check the below before submitting your PR. The PR will not be merged if there are no commits that start with docs: to indicate documentation changes or if the below checklist is not selected.

  • I confirm that there is no impact on the docs due to the code changes in this PR.

Signed-off-by: iromli <isman.firmansyah@gmail.com>
Copy link

dryrunsecurity bot commented Aug 23, 2024

DryRun Security Summary

The provided code changes span multiple Dockerfiles and scripts across various Janssen project components, primarily focusing on updating the build dates, source code versions, and various configuration settings for these components.

Expand for full summary

Summary:

The provided code changes span multiple Dockerfiles and scripts across various Janssen project components, including the Jans Config API, Jans Casa, Jans Certmanager, Jans Configurator, Jans FIDO2, Jans KC Scheduler, Jans Keycloak Link, Jans Link, Jans Monolith, Jans Persistence Loader, Jans SCIM, and Jans SAML. The changes primarily focus on updating the build dates, source code versions, and various configuration settings for these components.

From an application security perspective, the changes do not appear to introduce any obvious security vulnerabilities. However, it is important to review the overall security posture of the application, including the following aspects:

  1. Dependency Management: Ensure that all dependencies, including the base Docker images and third-party libraries, are kept up-to-date and do not contain any known security vulnerabilities.

  2. Secure Configuration: Review the environment variables and configuration settings to ensure that sensitive information, such as database credentials, API keys, and secrets, are properly managed and secured.

  3. Input Validation: Verify that the application properly validates and sanitizes all user input to prevent common web application vulnerabilities, such as SQL injection and cross-site scripting (XSS).

  4. Authentication and Authorization: Confirm that the application has robust authentication and authorization mechanisms in place to protect against unauthorized access.

  5. Secure Coding Practices: Review the application's source code to ensure that it follows secure coding practices and industry standards.

  6. Secure Deployment: Ensure that the Docker images are built and deployed in a secure manner, with appropriate security controls, such as image scanning, network segmentation, and access controls.

Files Changed:

The code changes span multiple files across various Janssen project components, including:

  • docker-jans-all-in-one/Dockerfile
  • docker-jans-auth-server/templates/jans-lock/clients.ldif
  • docker-jans-casa/Dockerfile
  • docker-jans-casa/scripts/upgrade.py
  • docker-jans-casa/scripts/bootstrap.py
  • docker-jans-casa/scripts/entrypoint.sh
  • docker-jans-config-api/Dockerfile
  • docker-jans-config-api/scripts/upgrade.py
  • docker-jans-certmanager/Dockerfile
  • docker-jans-configurator/Dockerfile
  • docker-jans-keycloak-link/Dockerfile
  • docker-jans-link/Dockerfile
  • docker-jans-monolith/Dockerfile
  • docker-jans-persistence-loader/Dockerfile
  • docker-jans-scim/Dockerfile
  • docker-jans-saml/Dockerfile

The changes in these files primarily focus on updating the build dates, source code versions, and various configuration settings for the different Janssen project components.

Code Analysis

We ran 9 analyzers against 19 files and 2 analyzers had findings. 7 analyzers had no findings.

Analyzer Findings
Sensitive Files Analyzer 14 findings
Authn/Authz Analyzer 2 findings

Riskiness

🟢 Risk threshold not exceeded.

View PR in the DryRun Dashboard.

iromli added 2 commits August 24, 2024 01:13
Signed-off-by: iromli <isman.firmansyah@gmail.com>
Signed-off-by: iromli <isman.firmansyah@gmail.com>
iromli and others added 2 commits August 27, 2024 01:11
@iromli iromli marked this pull request as ready for review August 26, 2024 18:12
@iromli iromli requested a review from moabu as a code owner August 26, 2024 18:12
@moabu moabu merged commit 39eb04d into main Aug 27, 2024
9 of 10 checks passed
@moabu moabu deleted the cn-sync-assets branch August 27, 2024 05:32
yuriyz pushed a commit that referenced this pull request Nov 7, 2024
* chore(cloud-native): sync assets for OCI images

Signed-off-by: iromli <isman.firmansyah@gmail.com>

* fix: remove duplicated jansAccessTknSigAlg attribute

Signed-off-by: iromli <isman.firmansyah@gmail.com>

* feat: add acrExclusionList config

Signed-off-by: iromli <isman.firmansyah@gmail.com>

* feat: agama flow for jans-casa installation

Signed-off-by: iromli <isman.firmansyah@gmail.com>

---------

Signed-off-by: iromli <isman.firmansyah@gmail.com>
Co-authored-by: Mohammad Abudayyeh <47318409+moabu@users.noreply.github.com>
Former-commit-id: 39eb04d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore(cloud-native): sync assets for OCI images
3 participants