Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cloud-native): update jans-pycloudlib version used by OCI images #9284

Merged
merged 3 commits into from
Aug 28, 2024

Conversation

iromli
Copy link
Contributor

@iromli iromli commented Aug 27, 2024

Prepare


Description

Target issue

closes #9283

Implementation Details


Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

Please check the below before submitting your PR. The PR will not be merged if there are no commits that start with docs: to indicate documentation changes or if the below checklist is not selected.

  • I confirm that there is no impact on the docs due to the code changes in this PR.

Signed-off-by: iromli <isman.firmansyah@gmail.com>
@iromli iromli requested a review from moabu as a code owner August 27, 2024 21:01
Copy link

dryrunsecurity bot commented Aug 27, 2024

DryRun Security Summary

The provided code changes focus on updating the Janssen project's Docker images to newer versions of the source code, with a strong emphasis on security-related practices such as dependency management, secure configuration, permissions and ownership, secrets management, and logging and monitoring.

Expand for full summary

Summary:

The provided code changes appear to be focused on updating the Janssen project's Docker images to newer versions of the source code. The updates span multiple components, including the All-in-One, Auth Server, Casa, Cert Manager, Config API, FIDO2, Configurator, KC Scheduler, Persistence Loader, Link, Keycloak Link, and SCIM Server.

The key security-related observations across these changes are:

  1. Dependency Management: The updates generally involve updating the JANS_SOURCE_VERSION environment variable, which likely includes security fixes and improvements to the underlying dependencies.

  2. Secure Configuration: The Dockerfiles set various environment variables to configure the applications, including settings for Consul, Vault, LDAP, Couchbase, and other services. Proper configuration of these components is crucial for maintaining the overall security of the system.

  3. Permissions and Ownership: The Dockerfiles create non-root users to run the applications and adjust file/directory permissions, which is a good security practice to minimize the potential impact of vulnerabilities.

  4. Secrets Management: The Dockerfiles handle various secrets, such as Vault role/secret IDs and Couchbase passwords, through environment variables. Ensuring the secure storage and handling of these secrets is essential.

  5. Logging and Monitoring: The Dockerfiles include configuration for logging and monitoring, such as setting up Prometheus, which can help with security-related incident detection and response.

Overall, the changes appear to be focused on maintaining and updating the Janssen project's Docker images, with a strong emphasis on security-related practices, such as dependency management, secure configuration, and least-privilege access. However, it is recommended to thoroughly review the updated source code and configurations to ensure that no new security vulnerabilities or risks are introduced.

Files Changed:

The following files were changed in this pull request:

  • docker-jans-all-in-one/Dockerfile
  • docker-jans-auth-server/Dockerfile
  • docker-jans-casa/Dockerfile
  • docker-jans-certmanager/Dockerfile
  • docker-jans-config-api/Dockerfile
  • docker-jans-fido2/Dockerfile
  • docker-jans-configurator/Dockerfile
  • docker-jans-kc-scheduler/Dockerfile
  • docker-jans-persistence-loader/Dockerfile
  • docker-jans-link/Dockerfile
  • docker-jans-keycloak-link/Dockerfile
  • docker-jans-saml/Dockerfile
  • docker-jans-scim/Dockerfile

Code Analysis

We ran 9 analyzers against 13 files and 1 analyzer had findings. 8 analyzers had no findings.

Analyzer Findings
Sensitive Files Analyzer 13 findings

Riskiness

🟢 Risk threshold not exceeded.

View PR in the DryRun Dashboard.

Signed-off-by: iromli <isman.firmansyah@gmail.com>
@moabu moabu merged commit d0938a6 into main Aug 28, 2024
11 checks passed
@moabu moabu deleted the cn-pycloudlib-version branch August 28, 2024 08:14
yuriyz pushed a commit that referenced this pull request Nov 7, 2024
…9284)

* fix(cloud-native): update jans-pycloudlib version used by OCI images

Signed-off-by: iromli <isman.firmansyah@gmail.com>

* fix(docker-jans-all-in-one): add missing casa-agama-project.zip

Signed-off-by: iromli <isman.firmansyah@gmail.com>

---------

Signed-off-by: iromli <isman.firmansyah@gmail.com>
Co-authored-by: Mohammad Abudayyeh <47318409+moabu@users.noreply.github.com>
Former-commit-id: d0938a6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix(cloud-native): update jans-pycloudlib version used by OCI images
3 participants