Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jans-cli-tui): authn page for non-ldap backend #9339

Merged
merged 2 commits into from
Sep 3, 2024

Conversation

devrimyatar
Copy link
Contributor

@devrimyatar devrimyatar commented Sep 3, 2024

closes #9330

  • I confirm that there is no impact on the docs due to the code changes in this PR.

Closes #9340,

Signed-off-by: Mustafa Baser <mbaser@mail.com>
@devrimyatar devrimyatar added kind-bug Issue or PR is a bug in existing functionality comp-jans-cli-tui Component affected by issue or PR labels Sep 3, 2024
@devrimyatar devrimyatar requested review from yuriyz and pujavs September 3, 2024 08:42
Copy link

dryrunsecurity bot commented Sep 3, 2024

DryRun Security Summary

The pull request focuses on the authentication server configuration in the Jans CLI TUI application, including changes to LDAP server configurations, custom authentication scripts, Agama flows, and ACR mappings, which require careful review and implementation of appropriate security measures to address security-sensitive areas.

Expand for full summary

Summary:

The code changes in this pull request are focused on the authentication server configuration in the Jans CLI TUI (Text-based User Interface) application. The key changes include the handling of LDAP server configurations, custom authentication scripts, Agama flows, and ACR (Authentication Context Reference) mappings. From an application security perspective, these changes introduce several security-sensitive areas that require careful review and implementation of appropriate security measures.

The LDAP server configuration includes sensitive information, such as bind DN and password, which should be properly protected through access control and encryption. The custom authentication scripts may contain security-sensitive logic and should be thoroughly reviewed and tested for vulnerabilities. The ACR mappings can be used to map user-supplied ACRs to different authentication methods, and it is crucial to implement proper input validation and sanitization to prevent potential injection attacks. Finally, the integration with the Agama module introduces additional complexity and potential attack surface, and the communication between the application and the Agama module should be properly secured.

Files Changed:

  • jans-cli-tui/cli_tui/plugins/010_auth_server/authn.py: This file handles the configuration of the authentication server in the Jans CLI TUI application. The key changes include:
    • LDAP server configuration: Allows users to add, edit, and delete LDAP server configurations, including sensitive information such as bind DN and password.
    • Authentication scripts: Supports the configuration of custom authentication scripts, which should be reviewed for security vulnerabilities.
    • Agama flows: Integrates with the Agama module to retrieve and display ACR values, introducing additional complexity and potential attack surface.
    • ACR mappings: Allows users to configure ACR mappings, which should be implemented with proper input validation and sanitization to prevent injection attacks.

Code Analysis

We ran 9 analyzers against 1 file and 0 analyzers had findings. 9 analyzers had no findings.

Riskiness

🟢 Risk threshold not exceeded.

View PR in the DryRun Dashboard.

@yuriyz yuriyz enabled auto-merge (squash) September 3, 2024 08:44
@yuriyz yuriyz merged commit 1addd62 into main Sep 3, 2024
11 checks passed
@yuriyz yuriyz deleted the jans-cli-tui-authn-9330 branch September 3, 2024 08:46
@mo-auto
Copy link
Member

mo-auto commented Sep 3, 2024

Error: Hi @devrimyatar, You did not reference an open issue in your PR. I attempted to create an issue for you.
Please update that issues' title and body and make sure I correctly referenced it in the above PRs body.

Copy link

sonarqubecloud bot commented Sep 3, 2024

Copy link

sonarqubecloud bot commented Sep 3, 2024

Copy link

sonarqubecloud bot commented Sep 3, 2024

Copy link

sonarqubecloud bot commented Sep 3, 2024

Copy link

sonarqubecloud bot commented Sep 3, 2024

yuriyz pushed a commit that referenced this pull request Nov 7, 2024
Signed-off-by: Mustafa Baser <mbaser@mail.com>
Former-commit-id: 1addd62
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp-jans-cli-tui Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: fix(jans-cli-tui): authn page for non-ldap backend -autocreated fix(jans-tui): Error on Jans TUI
4 participants