Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jans-core): fix javadocs generation #9347

Merged
merged 1 commit into from
Sep 3, 2024
Merged

feat(jans-core): fix javadocs generation #9347

merged 1 commit into from
Sep 3, 2024

Conversation

yurem
Copy link
Contributor

@yurem yurem commented Sep 3, 2024

closes #9346

  • I confirm that there is no impact on the docs due to the code changes in this PR.

Signed-off-by: Yuriy Movchan <Yuriy.Movchan@gmail.com>
@yurem yurem requested a review from yuremm September 3, 2024 14:25
@yurem yurem requested review from yuriyz and yuriyzz as code owners September 3, 2024 14:25
Copy link

dryrunsecurity bot commented Sep 3, 2024

DryRun Security Summary

The provided code change updates the pom.xml file in the jans-core project by updating the maven-site-plugin version and adding the maven-javadoc-plugin version, which are related to the build and deployment process of the project and do not directly introduce any security concerns.

Expand for full summary

Summary:

The provided code change is an update to the pom.xml file in the jans-core project. The changes involve updating the maven-site-plugin version from 4.0.0-M7 to 4.0.0-M16 and adding the maven-javadoc-plugin version 3.8.0. From an application security perspective, these changes do not directly introduce any security concerns, as they are related to the build and deployment process of the project, rather than the application's core functionality.

However, it's important to review the changelog and release notes of the updated plugins to ensure that there are no known security vulnerabilities or issues that could potentially impact the application. Additionally, keeping all dependencies and plugins up-to-date is recommended to address any security fixes or improvements. Overall, this code change appears to be a routine update to the project's build configuration and does not raise any immediate security concerns.

Files Changed:

  • jans-core/pom.xml: The changes in this file update the maven-site-plugin version from 4.0.0-M7 to 4.0.0-M16 and add the maven-javadoc-plugin version 3.8.0. These changes are related to the build and deployment process of the project and do not directly affect the application's security.

Code Analysis

We ran 9 analyzers against 1 file and 1 analyzer had findings. 8 analyzers had no findings.

Analyzer Findings
Sensitive Files Analyzer 1 finding

Riskiness

🟢 Risk threshold not exceeded.

View PR in the DryRun Dashboard.

@yurem yurem enabled auto-merge (squash) September 3, 2024 14:25
@mo-auto mo-auto added comp-jans-core Component affected by issue or PR kind-feature Issue or PR is a new feature request labels Sep 3, 2024
@yurem yurem merged commit 098ac14 into main Sep 3, 2024
11 checks passed
@yurem yurem deleted the fix_javadocs branch September 3, 2024 14:27
Copy link

sonarqubecloud bot commented Sep 3, 2024

yuriyz pushed a commit that referenced this pull request Nov 7, 2024
Signed-off-by: Yuriy Movchan <Yuriy.Movchan@gmail.com>
Former-commit-id: 098ac14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp-jans-core Component affected by issue or PR kind-feature Issue or PR is a new feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix(jans-core): fix javadocs generation
4 participants