Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: forces download each time on packaging #9356

Merged
merged 1 commit into from
Sep 4, 2024
Merged

ci: forces download each time on packaging #9356

merged 1 commit into from
Sep 4, 2024

Conversation

moabu
Copy link
Member

@moabu moabu commented Sep 4, 2024

Prepare


Description

Target issue

closes #9355

Implementation Details


Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

Please check the below before submitting your PR. The PR will not be merged if there are no commits that start with docs: to indicate documentation changes or if the below checklist is not selected.

  • I confirm that there is no impact on the docs due to the code changes in this PR.

Signed-off-by: moabu <47318409+moabu@users.noreply.github.com>
@moabu moabu added the area-CI Issue or changes required in automatic builds or CI infrastructure label Sep 4, 2024
Copy link

dryrunsecurity bot commented Sep 4, 2024

DryRun Security Summary

The pull request changes the GitHub Actions workflow for building and publishing packages for the Janssen Project, including triggering the workflow on a push event with a tag that starts with 'v', building packages for different Linux distributions, signing the built packages using GPG keys, and uploading the packages as GitHub releases, with a focus on security and integrity.

Expand for full summary

Summary:

The code changes in this pull request are related to the GitHub Actions workflow for building and publishing packages for the Janssen Project. The key changes include triggering the workflow on a push event with a tag that starts with 'v', building packages for different Linux distributions, signing the built packages using GPG keys, and uploading the packages as GitHub releases. From an application security perspective, the changes demonstrate a strong focus on security and integrity, including hardening the GitHub Actions runner, using GPG keys for package signing, and creating and uploading checksums for the built packages. Additionally, the workflow builds and uploads demo packages, which should be carefully reviewed to ensure they do not contain any security vulnerabilities or sensitive data.

Files Changed:

  • .github/workflows/build-packages.yml: This file contains the GitHub Actions workflow for building and publishing packages for the Janssen Project. The key changes include:
    • Triggering the workflow on a push event with a tag that starts with 'v'.
    • Building packages for Ubuntu 22.04, Ubuntu 20.04, CentOS 8, and SUSE 15.
    • Installing necessary dependencies, including Python versions, and running the install.py script to build the packages.
    • Signing the built packages using GPG keys and uploading them as GitHub releases.
    • Building Python packages (jans-linux-setup and jans-cli-tui) for Ubuntu and SUSE, and uploading them as GitHub releases.
    • Building and uploading demo packages (jans-tarp) as GitHub releases.
    • Using the step-security/harden-runner action to harden the GitHub Actions runner.
    • Importing and using GPG keys for signing the built packages.
    • Using the svenstaro/upload-release-action action to upload the built packages to GitHub releases.
    • Creating and uploading checksums for the built packages.

Code Analysis

We ran 9 analyzers against 1 file and 0 analyzers had findings. 9 analyzers had no findings.

Riskiness

🟢 Risk threshold not exceeded.

View PR in the DryRun Dashboard.

@moabu moabu merged commit ee5ee53 into main Sep 4, 2024
11 checks passed
@moabu moabu deleted the ci-fix-packaging branch September 4, 2024 06:30
yuriyz pushed a commit that referenced this pull request Nov 7, 2024
Signed-off-by: moabu <47318409+moabu@users.noreply.github.com>
Former-commit-id: ee5ee53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-CI Issue or changes required in automatic builds or CI infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci: linux packages aren’t pulling the latest projects
1 participant