-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(jans-pycloudlib): handle required files for external configuration backends #9389
Conversation
…on backends Signed-off-by: iromli <isman.firmansyah@gmail.com>
DryRun Security SummaryThe pull request covers various updates to the Expand for full summarySummary: The code changes in this pull request cover various aspects of the From an application security perspective, the changes do not introduce any obvious security concerns. The addition of a new dependency, the improvements to the testing coverage, the proper handling of Google Application Credentials, and the refactoring of the manager classes all contribute to a more secure and maintainable codebase. However, it's important to note that the overall security of the application would depend on how the Files Changed:
Code AnalysisWe ran Riskiness🟢 Risk threshold not exceeded. |
…ersistence Signed-off-by: iromli <isman.firmansyah@gmail.com>
…et-manager lib Signed-off-by: iromli <isman.firmansyah@gmail.com>
|
|
|
…on backends (#9389) * feat(jans-pycloudlib): handle required files for external configuration backends Signed-off-by: iromli <isman.firmansyah@gmail.com> * feat(jans-pycloudlib): populate google credentials if using spanner persistence Signed-off-by: iromli <isman.firmansyah@gmail.com> * fix(jans-pycloudlib): resolve broken dependency for google-cloud-secret-manager lib Signed-off-by: iromli <isman.firmansyah@gmail.com> --------- Signed-off-by: iromli <isman.firmansyah@gmail.com> Co-authored-by: Mohammad Abudayyeh <47318409+moabu@users.noreply.github.com> Former-commit-id: 3c14434
Prepare
Description
Added methods in jans-pycloudlib to bootstrap required assets for external configuration backends (AWS/Google/Vault). A separate PR is needed to sync OCI images to use this new version of jans-pycloudlib.
Target issue
closes #9368
Implementation Details
Test and Document the changes
Please check the below before submitting your PR. The PR will not be merged if there are no commits that start with
docs:
to indicate documentation changes or if the below checklist is not selected.