Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: high CPU usage on opening tarp #9390 #9391

Merged
merged 4 commits into from
Sep 9, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
feat: resolving review comments
Signed-off-by: Arnab Dutta <arnab.bdutta@gmail.com>
duttarnab committed Sep 6, 2024

Verified

This commit was signed with the committer’s verified signature.
duttarnab Arnab Dutta
commit 2b6bc83628cee544dc840efa6f2c9dfe5c63aa16
16 changes: 4 additions & 12 deletions demos/jans-tarp/src/options/oidcClients.tsx
Original file line number Diff line number Diff line change
@@ -88,16 +88,12 @@ function Row(props: { row: ReturnType<typeof createData>, notifyOnDataChange })
chrome.storage.local.set({ oidcClients: clientArr.filter(obj => obj.clientId !== row.clientId) });
}
});
handleNotifyOnDataChange();
}

const handleNotifyOnDataChange = () => {
notifyOnDataChange();
};
}

return (
<React.Fragment>
<AuthFlowInputs isOpen={open} handleDialog={handleDialog} client={row} notifyOnDataChange={handleNotifyOnDataChange}/>
<AuthFlowInputs isOpen={open} handleDialog={handleDialog} client={row} notifyOnDataChange={notifyOnDataChange}/>
<TableRow sx={{ '& > *': { borderBottom: 'unset' } }}>
<TableCell>
<Tooltip title="Delete Client from jans-tarp">
@@ -145,10 +141,6 @@ export default function OIDCClients({ data, notifyOnDataChange }) {
setDrawerOpen(isOpen);
};

const handleNotifyOnDataChange = () => {
notifyOnDataChange();
};

return (
<Container maxWidth="lg">
<RegisterClient isOpen={modelOpen} handleDialog={handleDialog} />
@@ -172,9 +164,9 @@ export default function OIDCClients({ data, notifyOnDataChange }) {
</TableRow>
</TableHead>
<TableBody>
{(data === undefined || data.length == 0) ?
{(data === undefined || data?.length == 0) ?
<TableCell colSpan={6}><Alert severity="warning">No Records to show.</Alert></TableCell> :
data.map((row) => (<Row key={row.clientId} row={row} notifyOnDataChange={handleNotifyOnDataChange} />))
data.map((row) => (<Row key={row?.clientId} row={row} notifyOnDataChange={notifyOnDataChange} />))
}
</TableBody>
</Table>
2 changes: 1 addition & 1 deletion demos/jans-tarp/src/options/userDetails.tsx
Original file line number Diff line number Diff line change
@@ -62,7 +62,7 @@ const UserDetails = ({data, notifyOnDataChange}) => {
</div>
<legend><span className="number">O</span> User Details:</legend>
<hr />
{data.displayToken ?
{data?.displayToken ?
<>
<div className="alert alert-success alert-dismissable fade in">
<strong>Access Token</strong>